From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhDgA-0005dp-Uc for qemu-devel@nongnu.org; Wed, 30 Sep 2015 05:28:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhDCN-00023t-Qq for qemu-devel@nongnu.org; Wed, 30 Sep 2015 04:57:54 -0400 From: Markus Armbruster References: <1443530263-32340-1-git-send-email-pbonzini@redhat.com> <1443530263-32340-3-git-send-email-pbonzini@redhat.com> Date: Wed, 30 Sep 2015 10:57:12 +0200 In-Reply-To: <1443530263-32340-3-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Tue, 29 Sep 2015 14:37:42 +0200") Message-ID: <87eghg8etz.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, qemu-ppc@nongnu.org Paolo Bonzini writes: > This causes the region to outlive the object, because it attaches the > region to /machine. This is not nice for the "realize" method, but > much worse for "instance_init" because it can cause dangling pointers > after a simple object_new/object_unref pair. > > Reported-by: Markus Armbruster > Signed-off-by: Paolo Bonzini One more: pxa2xx_pcmcia_initfn(). The ones you fix are Tested-by: Markus Armbruster