From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbbIHHVd (ORCPT ); Tue, 8 Sep 2015 03:21:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33017 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbbIHHVa (ORCPT ); Tue, 8 Sep 2015 03:21:30 -0400 From: Vitaly Kuznetsov To: Stephen Hemminger Cc: "K. Y. Srinivasan" , Haiyang Zhang , Greg Kroah-Hartman , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hyperv: fix build if KEXEC not enabled References: <20150907102222.27d0477b@urahara> Date: Tue, 08 Sep 2015 09:21:25 +0200 In-Reply-To: <20150907102222.27d0477b@urahara> (Stephen Hemminger's message of "Mon, 7 Sep 2015 10:22:22 -0700") Message-ID: <87egi9bclm.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Hemminger writes: > Fixes regression 4.3 mergw window in my config > where hyperv is enable but CONFIG_KEXEC not enabled. > > arch/x86/kernel/cpu/mshyperv.c:112: undefined reference to `native_machine_crash_shutdown' > > Introduced by: > commit b4370df2b1f5158de028e167974263c5757b34a6 > Author: Vitaly Kuznetsov > Date: Sat Aug 1 16:08:09 2015 -0700 > > Drivers: hv: vmbus: add special crash handler > > Signed-off-by: Stephen Hemminger > > --- a/arch/x86/kernel/cpu/mshyperv.c 2015-09-07 10:11:24.994885115 -0700 > +++ b/arch/x86/kernel/cpu/mshyperv.c 2015-09-07 10:14:20.995698615 -0700 > @@ -109,7 +109,9 @@ static void hv_machine_crash_shutdown(st > { > if (hv_crash_handler) > hv_crash_handler(regs); > +#ifdef CONFIG_KEXEC > native_machine_crash_shutdown(regs); > +#endif > } Greg in particular was against #ifdefs in C code and I sent the following patch to fix the issue: https://lkml.org/lkml/2015/8/11/417 -- Vitaly