Re: [PATCH v10 11/11] (lib)xl: soft reset support

[Vitaly Kuznetsov <vkuznets@redhat.com>]

Wei Liu <wei.liu2@citrix.com> writes:

> [...]
>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
>> index 9f6ec00..87d8255 100644
>> --- a/tools/libxl/libxl_types.idl
>> +++ b/tools/libxl/libxl_types.idl
>> @@ -138,6 +138,8 @@ libxl_action_on_shutdown = Enumeration("action_on_shutdown", [
>>  
>>      (5, "COREDUMP_DESTROY"),
>>      (6, "COREDUMP_RESTART"),
>> +
>
> Stray blank line.
>

Actually, we already have a number of blank lines here (to group similar
actions I think), e.g. between 1 and 2, 3 and 4, 4 and 5 so I'm kinda
following the convention :-) Do you think we need to remove them all or
is 'SOFT_RESET' a bit special and belongs to the 'COREDUMP*' group?

>> +    (7, "SOFT_RESET"),
>>      ], init_val = "LIBXL_ACTION_ON_SHUTDOWN_DESTROY")
>>  
>>  libxl_trigger = Enumeration("trigger", [
>> diff --git a/tools/libxl/xl.h b/tools/libxl/xl.h
>> index 6c19c0d..0021112 100644
>> --- a/tools/libxl/xl.h
>> +++ b/tools/libxl/xl.h
>> @@ -194,6 +194,7 @@ typedef enum {
>>      DOMAIN_RESTART_NONE = 0,     /* No domain restart */
>>      DOMAIN_RESTART_NORMAL,       /* Domain should be restarted */
>>      DOMAIN_RESTART_RENAME,       /* Domain should be renamed and restarted */
>> +    DOMAIN_RESTART_SOFT_RESET,   /* Soft reset should be performed */
>>  } domain_restart_type;
>>  
>>  extern void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh);
>> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
>> index 2e9e1bd..0b29d34 100644
>> --- a/tools/libxl/xl_cmdimpl.c
>> +++ b/tools/libxl/xl_cmdimpl.c
>> @@ -133,6 +133,8 @@ static const char *action_on_shutdown_names[] = {
>>  
>>      [LIBXL_ACTION_ON_SHUTDOWN_COREDUMP_DESTROY] = "coredump-destroy",
>>      [LIBXL_ACTION_ON_SHUTDOWN_COREDUMP_RESTART] = "coredump-restart",
>> +
>
> Stray blank line.
>

Same here (for same reasons I suppose).

[...]

-- 
  Vitaly