From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH v10 11/11] (lib)xl: soft reset support
Date: Tue, 01 Sep 2015 19:26:49 +0200
Message-ID: <87egiidp9i.fsf@vitty.brq.redhat.com>
References: <1438090096-8297-1-git-send-email-vkuznets@redhat.com>
	<1438090096-8297-12-git-send-email-vkuznets@redhat.com>
	<20150831141417.GF22586@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <vkuznets@redhat.com>) id 1ZWpKm-0000ef-1Y
	for xen-devel@lists.xenproject.org; Tue, 01 Sep 2015 17:27:00 +0000
In-Reply-To: <20150831141417.GF22586@zion.uk.xensource.com> (Wei Liu's message
	of "Mon, 31 Aug 2015 15:14:17 +0100")
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Jones <drjones@redhat.com>, Julien Grall <julien.grall@linaro.org>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Olaf Hering <olaf@aepfle.de>, Tim Deegan <tim@xen.org>, David Vrabel <david.vrabel@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

Wei Liu <wei.liu2@citrix.com> writes:

> [...]
>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
>> index 9f6ec00..87d8255 100644
>> --- a/tools/libxl/libxl_types.idl
>> +++ b/tools/libxl/libxl_types.idl
>> @@ -138,6 +138,8 @@ libxl_action_on_shutdown = Enumeration("action_on_shutdown", [
>>  
>>      (5, "COREDUMP_DESTROY"),
>>      (6, "COREDUMP_RESTART"),
>> +
>
> Stray blank line.
>

Actually, we already have a number of blank lines here (to group similar
actions I think), e.g. between 1 and 2, 3 and 4, 4 and 5 so I'm kinda
following the convention :-) Do you think we need to remove them all or
is 'SOFT_RESET' a bit special and belongs to the 'COREDUMP*' group?

>> +    (7, "SOFT_RESET"),
>>      ], init_val = "LIBXL_ACTION_ON_SHUTDOWN_DESTROY")
>>  
>>  libxl_trigger = Enumeration("trigger", [
>> diff --git a/tools/libxl/xl.h b/tools/libxl/xl.h
>> index 6c19c0d..0021112 100644
>> --- a/tools/libxl/xl.h
>> +++ b/tools/libxl/xl.h
>> @@ -194,6 +194,7 @@ typedef enum {
>>      DOMAIN_RESTART_NONE = 0,     /* No domain restart */
>>      DOMAIN_RESTART_NORMAL,       /* Domain should be restarted */
>>      DOMAIN_RESTART_RENAME,       /* Domain should be renamed and restarted */
>> +    DOMAIN_RESTART_SOFT_RESET,   /* Soft reset should be performed */
>>  } domain_restart_type;
>>  
>>  extern void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh);
>> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
>> index 2e9e1bd..0b29d34 100644
>> --- a/tools/libxl/xl_cmdimpl.c
>> +++ b/tools/libxl/xl_cmdimpl.c
>> @@ -133,6 +133,8 @@ static const char *action_on_shutdown_names[] = {
>>  
>>      [LIBXL_ACTION_ON_SHUTDOWN_COREDUMP_DESTROY] = "coredump-destroy",
>>      [LIBXL_ACTION_ON_SHUTDOWN_COREDUMP_RESTART] = "coredump-restart",
>> +
>
> Stray blank line.
>

Same here (for same reasons I suppose).

[...]

-- 
  Vitaly