From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxFrj-00070a-AM for qemu-devel@nongnu.org; Tue, 26 May 2015 10:30:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxFrf-0003KC-4c for qemu-devel@nongnu.org; Tue, 26 May 2015 10:29:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxFre-0003K4-WE for qemu-devel@nongnu.org; Tue, 26 May 2015 10:29:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 943B8C12FA for ; Tue, 26 May 2015 14:29:54 +0000 (UTC) From: Markus Armbruster References: <1432322539-23719-1-git-send-email-thuth@redhat.com> <20150526125235.GJ13262@stefanha-thinkpad.redhat.com> Date: Tue, 26 May 2015 16:29:51 +0200 In-Reply-To: <20150526125235.GJ13262@stefanha-thinkpad.redhat.com> (Stefan Hajnoczi's message of "Tue, 26 May 2015 13:52:35 +0100") Message-ID: <87egm34dk0.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too, List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Thomas Huth , Jason Wang , "Michael S. Tsirkin" Stefan Hajnoczi writes: > On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote: >> So far, it is not possible to use the network dump interface >> with the "-netdev" option yet, it only works with the legacy >> "-net" option. To be able to use it with "-netdev", too, this >> patch now enables the "vlan" packet distribution for the >> "-netdev" option, too, so that you can now dump network packets >> like this: >> >> qemu... -device e1000,netdev=myhub -netdev hubport,hubid=1,id=myhub \ >> -netdev user,id=n1,vlan=1,tftp=/tmp/tftp,bootfile=zImage \ >> -netdev dump,id=n2,vlan=1,file=/tmp/dump.dat >> >> Signed-off-by: Thomas Huth >> --- >> net/net.c | 3 +++ >> qapi-schema.json | 1 + >> 2 files changed, 4 insertions(+) >> >> [Note: I'm quite new to this area of the code, please review carefully >> whether this approach makes sense or whether it should be done differently] > > We thought the QEMU "vlan" concept would be dropped completely in the > future, so it was never added to -netdev. No patches to do that have > been posted over the years, so I think it was more of a conceptual goal > than a concrete requirement. Well, patches to do that first need to replace the VLAN-only dump feature. To fully deprecate -net, we also have to replace -net nic for configuring onboard NICs. Prior discussion: http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg03743.html We haven't really tried either. Thomas's patch declares defeat on VLANs: it ports them to -netdev, perpetuating the concept. > I'm okay with merging this but will leave some time for discussion > before merging the patch. > > "Speak now or forever hold your peace" Sure we're ready to give up without having tried?