From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YViFi-0007OV-Pg for qemu-devel@nongnu.org; Wed, 11 Mar 2015 11:08:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YViFf-0002Br-HL for qemu-devel@nongnu.org; Wed, 11 Mar 2015 11:08:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YViFf-0002BW-7p for qemu-devel@nongnu.org; Wed, 11 Mar 2015 11:08:51 -0400 From: Markus Armbruster References: <1423064635-19045-1-git-send-email-marcel@redhat.com> <1423064635-19045-8-git-send-email-marcel@redhat.com> <54FF2EE0.9010401@suse.de> <20150310222233-mutt-send-email-mst@redhat.com> <54FF63F8.5030406@suse.de> <20150311094824-mutt-send-email-mst@redhat.com> Date: Wed, 11 Mar 2015 16:08:16 +0100 In-Reply-To: <20150311094824-mutt-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Wed, 11 Mar 2015 09:56:05 +0100") Message-ID: <87egovwp0f.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, Marcel Apfelbaum , jan.kiszka@siemens.com, Riku Voipio , cornelia.huck@de.ibm.com, qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, scottwood@freescale.com, pbonzini@redhat.com, leon.alrae@imgtec.com, Andreas =?utf-8?Q?F=C3=A4rber?= , aurelien@aurel32.net "Michael S. Tsirkin" writes: > On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas F=C3=A4rber wrote: >> Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: >> > On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas F=C3=A4rber wrote: >> >> Hi, >> >> >> >> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: >> >>> Fixes a QEMU crash when passing dump_guest_core parameter in command= line. >> >> >> >> Explain that, please? >> >=20 >> > Pls note the submission date. It's 1 month late to ask for >> > basic clarifications. >> >=20 >> > I've merged the patches, I'll fix up issues such as prettifying >> > includes by adding patches on top. >>=20 >> No, since the patch is not in qemu.git (it builds!) it is not too late >> to fix it, nor too late to ask why a patch that introduces a breakage >> does what it does. > > > I tried to say that I'm not holding this patch set up > because there are some basic questions. Paolo reviewed > it and gave an ack. If others want to re-start review 1 month > afterwards, that's fine, but I don't want to defer pull > request with this any longer. If someone can quickly spot > a serious non-cosmetic problem there, that's another > matter, and would make me defer the pull request. Okay, sounds much more reasonable than your first reply. Thanks for clarifying. [...]