All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ed Maste <carpeddiem@gmail.com>, intel-gfx@lists.freedesktop.org
Subject: Re: Multiple declarations for intel_fbc_enabled
Date: Wed, 04 Feb 2015 15:27:18 +0200	[thread overview]
Message-ID: <87egq5yfgp.fsf@intel.com> (raw)
In-Reply-To: <CAPyFy2DiDmU0TazXr02K0v1aZ-pbT22HhS3548Xy74+Cp27CbQ@mail.gmail.com>

On Mon, 02 Feb 2015, Ed Maste <carpeddiem@gmail.com> wrote:
> A FreeBSD developer discovered that intel_fbc_enabled has a
> declaration in two headers:
>
> sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
> sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
>
> We have a slightly older version of the i915 driver on FreeBSD, but I
> see that this is still the case in Linux (although the "extern" has
> been removed from one of them). Commit 85208be added the one in
> intel_drv.h and didn't remove the existing one.

Fixed by

commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date:   Mon Dec 8 14:09:10 2014 -0200

    drm/i915: Move FBC stuff to intel_fbc.c

which is queued for v3.20.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-02-04 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 15:42 Multiple declarations for intel_fbc_enabled Ed Maste
2015-02-04 13:27 ` Jani Nikula [this message]
2015-02-05  2:24   ` Ed Maste
  -- strict thread matches above, loose matches on Subject: below --
2015-02-02 16:40 Ed Maste
2015-02-02 17:46 ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egq5yfgp.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=carpeddiem@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.