From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ander Conselvan de Oliveira <conselvan2@gmail.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix all pipe->plane mappings before sanitizing crtc
Date: Wed, 14 Jan 2015 13:06:41 +0200 [thread overview]
Message-ID: <87egqxfwou.fsf@intel.com> (raw)
In-Reply-To: <54B64A06.4040901@gmail.com>
On Wed, 14 Jan 2015, Ander Conselvan de Oliveira <conselvan2@gmail.com> wrote:
> On 01/14/2015 12:47 PM, Jani Nikula wrote:
>> On Tue, 13 Jan 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
>>> If QUIRK_PIPEA_FORCE is necessary, intel_sanitize_crtc() might trigger
>>> a mode set. In that case, if pipe A is disabled and pipe B is mapped to
>>> plane B, that mode set happens before the mapping is fixed. Due to the
>>> wrong state, the call to disable pipe B disables plane A (which is
>>> already disabled) and later an assertion for plane B being enabled
>>> (while it should have been disabled) is triggered.
>>>
>>> References: https://bugs.freedesktop.org/show_bug.cgi?id=72782
>>
>> If the patch is expected to fix the bug, please use Bugzilla:. If you're
>> referencing a bug because it's otherwise relevant, please use
>> References:.
>>
>> Which one is this?
>
> This showed up in the dmesg attached to the referenced bug, but is not
> the root cause of the reported problem. As far as I know, there is no
> open bug for this particular issue.
Ah, so it's correct as it is. Sorry for the noise. Please carry on.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-01-14 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 7:59 [PATCH] drm/i915: Fix all pipe->plane mappings before sanitizing crtc Ander Conselvan de Oliveira
2015-01-13 15:53 ` shuang.he
2015-01-14 10:47 ` Jani Nikula
2015-01-14 10:50 ` Ander Conselvan de Oliveira
2015-01-14 11:00 ` Chris Wilson
2015-01-14 11:06 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egqxfwou.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.