From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XsrGt-0003Zc-KS for ath10k@lists.infradead.org; Mon, 24 Nov 2014 10:53:34 +0000 From: Kalle Valo Subject: Re: [PATCH 2/2] ath10k: re-config ht_caps when chainmask is modified. References: <1411576506-11815-1-git-send-email-greearb@candelatech.com> <1411576506-11815-2-git-send-email-greearb@candelatech.com> <87ioi47vvd.fsf@kamboji.qca.qualcomm.com> Date: Mon, 24 Nov 2014 12:53:04 +0200 In-Reply-To: <87ioi47vvd.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 24 Nov 2014 12:09:42 +0200") Message-ID: <87egss7tv3.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: greearb@candelatech.com Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Kalle Valo writes: >> @@ -2537,6 +2560,17 @@ static int __ath10k_set_antenna(struct ath10k *ar, u32 tx_ant, u32 rx_ant) >> ar->cfg_tx_chainmask = tx_ant; >> ar->cfg_rx_chainmask = rx_ant; >> >> + ht_cap = ath10k_get_ht_cap(ar, true); >> + vht_cap = ath10k_create_vht_cap(ar, true); >> + >> + if (ar->phy_capability & WHAL_WLAN_11G_CAPABILITY) >> + ar->mac.sbands[IEEE80211_BAND_2GHZ].ht_cap = ht_cap; >> + >> + if (ar->phy_capability & WHAL_WLAN_11A_CAPABILITY) { >> + ar->mac.sbands[IEEE80211_BAND_5GHZ].ht_cap = ht_cap; >> + ar->mac.sbands[IEEE80211_BAND_5GHZ].vht_cap = vht_cap; >> + } > > So this modifies stryct wiphy::bands after we have called > ieee80211_register_hw(). Is this something which both cfg80211 and > mac80211 support? I didn't find the documentation mentioning anything > about this so I got a bit worried. Johannes mentioned me that this is not supported so I am reluctant to take these. Unless I'm missing something, of course. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:34949 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbaKXKxL (ORCPT ); Mon, 24 Nov 2014 05:53:11 -0500 From: Kalle Valo To: CC: , Subject: Re: [PATCH 2/2] ath10k: re-config ht_caps when chainmask is modified. References: <1411576506-11815-1-git-send-email-greearb@candelatech.com> <1411576506-11815-2-git-send-email-greearb@candelatech.com> <87ioi47vvd.fsf@kamboji.qca.qualcomm.com> Date: Mon, 24 Nov 2014 12:53:04 +0200 In-Reply-To: <87ioi47vvd.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 24 Nov 2014 12:09:42 +0200") Message-ID: <87egss7tv3.fsf@kamboji.qca.qualcomm.com> (sfid-20141124_115314_733881_BD836E6F) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: >> @@ -2537,6 +2560,17 @@ static int __ath10k_set_antenna(struct ath10k *ar, u32 tx_ant, u32 rx_ant) >> ar->cfg_tx_chainmask = tx_ant; >> ar->cfg_rx_chainmask = rx_ant; >> >> + ht_cap = ath10k_get_ht_cap(ar, true); >> + vht_cap = ath10k_create_vht_cap(ar, true); >> + >> + if (ar->phy_capability & WHAL_WLAN_11G_CAPABILITY) >> + ar->mac.sbands[IEEE80211_BAND_2GHZ].ht_cap = ht_cap; >> + >> + if (ar->phy_capability & WHAL_WLAN_11A_CAPABILITY) { >> + ar->mac.sbands[IEEE80211_BAND_5GHZ].ht_cap = ht_cap; >> + ar->mac.sbands[IEEE80211_BAND_5GHZ].vht_cap = vht_cap; >> + } > > So this modifies stryct wiphy::bands after we have called > ieee80211_register_hw(). Is this something which both cfg80211 and > mac80211 support? I didn't find the documentation mentioning anything > about this so I got a bit worried. Johannes mentioned me that this is not supported so I am reluctant to take these. Unless I'm missing something, of course. -- Kalle Valo