From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: IRQ #0 broken on ARM
Date: Fri, 21 Nov 2014 22:32:48 +0100 [thread overview]
Message-ID: <87egsw5jen.fsf@free.fr> (raw)
In-Reply-To: <546F1F45.7080103@arm.com> (Marc Zyngier's message of "Fri, 21 Nov 2014 11:17:25 +0000")
Marc Zyngier <marc.zyngier@arm.com> writes:
>> Linus has decreed it to not be a valid IRQ number, and that's basically
>> the end of the discussion. Generic code, and drivers, will increasingly
>> decide that IRQ0 is not valid, and objecting to it has, and will continue
>> to elicit a response of "fix ARM".
>
> I'm fine with that.
For pxa, why not do something like that [1] ?
Cheers.
--
Robert
[1]
---8>---
>From 551eaf75934bd84939a40781470ed3c04d17507a Mon Sep 17 00:00:00 2001
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Fri, 21 Nov 2014 22:11:42 +0100
Subject: [PATCH] ARM: pxa: arbitrarily set first interrupt number
As IRQ0, the legacy timer interrupt should not be used as an interrupt
number, shift the interrupts by a fixed number.
As we had in a special case a shift of 16 when ISA bus was used on a
PXA, use that value as the first interrupt number, regardless of ISA or
not.
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
arch/arm/mach-pxa/include/mach/irqs.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-pxa/include/mach/irqs.h b/arch/arm/mach-pxa/include/mach/irqs.h
index 48c2fd8..9d8983f 100644
--- a/arch/arm/mach-pxa/include/mach/irqs.h
+++ b/arch/arm/mach-pxa/include/mach/irqs.h
@@ -14,12 +14,9 @@
#ifdef CONFIG_PXA_HAVE_ISA_IRQS
#define PXA_ISA_IRQ(x) (x)
-#define PXA_ISA_IRQ_NUM (16)
-#else
-#define PXA_ISA_IRQ_NUM (0)
#endif
-#define PXA_IRQ(x) (PXA_ISA_IRQ_NUM + (x))
+#define PXA_IRQ(x) (16 + (x))
#define IRQ_SSP3 PXA_IRQ(0) /* SSP3 service request */
#define IRQ_MSL PXA_IRQ(1) /* MSL Interface interrupt */
--
2.1.0
next prev parent reply other threads:[~2014-11-21 21:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 10:31 IRQ #0 broken on ARM Dmitry Eremin-Solenikov
2014-11-21 10:34 ` Russell King - ARM Linux
2014-11-21 10:51 ` Dmitry Eremin-Solenikov
2014-11-21 10:53 ` Uwe Kleine-König
2014-11-21 10:55 ` Dmitry Eremin-Solenikov
2014-11-21 10:52 ` Marc Zyngier
2014-11-21 11:01 ` Dmitry Eremin-Solenikov
2014-11-21 11:01 ` Russell King - ARM Linux
2014-11-21 11:17 ` Marc Zyngier
2014-11-21 21:32 ` Robert Jarzmik [this message]
2014-11-21 22:20 ` Dmitry Eremin-Solenikov
2014-11-21 22:27 ` Rob Herring
2014-11-22 12:18 ` Robert Jarzmik
2014-11-22 12:40 ` Dmitry Eremin-Solenikov
2014-11-22 12:55 ` Robert Jarzmik
2014-11-21 22:31 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egsw5jen.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.