From: Dmitry Monakhov <dmonakhov@openvz.org>
To: "Lukáš Czerner" <lczerner@redhat.com>, "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Explicitly inform user about orphan list cleanup.
Date: Thu, 18 Sep 2014 13:30:36 +0400 [thread overview]
Message-ID: <87egv9tgw3.fsf@openvz.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1409181048460.3870@localhost.localdomain>
On Thu, 18 Sep 2014 10:49:56 +0200 (CEST), Lukáš Czerner <lczerner@redhat.com> wrote:
> On Thu, 18 Sep 2014, Theodore Ts'o wrote:
>
> > Date: Thu, 18 Sep 2014 00:29:07 -0400
> > From: Theodore Ts'o <tytso@mit.edu>
> > To: Dmitry Monakhov <dmonakhov@openvz.org>
> > Cc: linux-ext4@vger.kernel.org
> > Subject: Re: [PATCH 2/2] ext4: Explicitly inform user about orphan list
> > cleanup.
> >
> > On Sun, Sep 14, 2014 at 04:38:57PM +0400, Dmitry Monakhov wrote:
> > > Production fs likely compiled/mounted w/o jbd debugging, so orphan list clearing
> > > will be silent.
> > >
> > > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> >
> > Thanks, applied.
>
> Hmm did not we just take this out recently with
>
> 566370a2e56837be98bc62d012fc2d2d11851db4 ext4: suppress ext4 orphan
> messages on mount
The message I want to change appears only if file system contains
errors. So IMHO this is reasonable to make this message louder.
This is important because after orphan list will be directly cleared
later fsck will complain about incorrect dtime and corrupted orphan list.
Sane administrator should investigate why this happen. So leaving
precise message in /var/log/messages is good practice from our side.
>
> and TBH I like it that way.
>
> Thanks!
> -Lukas
>
> >
> > - Ted
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-18 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 12:38 [PATCH 1/2] jbd2: jbd2_log_wait_for_space improve error detetcion Dmitry Monakhov
2014-09-14 12:38 ` [PATCH 2/2] ext4: Explicitly inform user about orphan list cleanup Dmitry Monakhov
2014-09-18 4:29 ` Theodore Ts'o
2014-09-18 8:49 ` Lukáš Czerner
2014-09-18 9:30 ` Dmitry Monakhov [this message]
2014-09-18 9:44 ` Lukáš Czerner
2014-09-16 18:51 ` [PATCH 1/2] jbd2: jbd2_log_wait_for_space improve error detetcion Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egv9tgw3.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.