From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Wi4HL-0008T8-1M
	for qemu-devel@nongnu.org; Wed, 07 May 2014 12:01:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Wi4HF-0004Ci-W6
	for qemu-devel@nongnu.org; Wed, 07 May 2014 12:01:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64844)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Wi4HF-0004Ce-OU
	for qemu-devel@nongnu.org; Wed, 07 May 2014 12:01:01 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1399030002-27222-1-git-send-email-armbru@redhat.com>
	<20140507103012.10d258a0@redhat.com>
Date: Wed, 07 May 2014 18:00:39 +0200
In-Reply-To: <20140507103012.10d258a0@redhat.com> (Luiz Capitulino's message
	of "Wed, 7 May 2014 10:30:12 -0400")
Message-ID: <87eh05wpco.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Fri,  2 May 2014 13:26:28 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> I got a private branch getting rid of it entirely.  This is the fifth
>> part, covering QMP and the guest agent up to the point where I start
>> messing with the QAPI code generators.  That's left for the final
>> part.
>>=20
>> Luiz agreed to take this through his tree.
>>=20
>> This series conflicts with Llu=C3=ADs's "qapi: Allow modularization of Q=
API
>> schema files", but only in docs/writing-qmp-commands.txt, and
>> resolution is trivial.
>
> I didn't get any conflicts.

Even better :)

> Have you looked at Laszlo series to make sure it follows your guidelines?
>
>  http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg01506.html

Looks fine to me at a glance: no new error_is_set(), all Error * and
Error ** variables are nicely named.

> I've already applied his series to my tree, btw. Yours is on top.
>
> Applied to the qmp branch, thanks.

Thanks!