From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WS1oI-0001ox-2K for ath10k@lists.infradead.org; Mon, 24 Mar 2014 10:08:50 +0000 From: Kalle Valo Subject: Re: [PATCH 2/2] ath10k: fix rssi and rate reporting References: <1395394437-4048-1-git-send-email-janusz.dziedzic@tieto.com> <1395394437-4048-2-git-send-email-janusz.dziedzic@tieto.com> Date: Mon, 24 Mar 2014 12:08:21 +0200 In-Reply-To: <1395394437-4048-2-git-send-email-janusz.dziedzic@tieto.com> (Janusz Dziedzic's message of "Fri, 21 Mar 2014 10:33:57 +0100") Message-ID: <87eh1r7vu2.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Janusz Dziedzic Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Janusz Dziedzic writes: > RSSI and RATE fields are valid only when START_VALID > bit is set. So, in current implementation we have to > remember/caclulate them when START_VALID and report the same > when only END_VALID is set. In other case during high > RX traffic we will report invalid RSSI (-95) and RATE (6Mbps) > when only END_VALID bit set. > > Signed-off-by: Janusz Dziedzic It's not clear for me what (user visible) bug you are fixing, please describe that in the commit log. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:6164 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbaCXKIk (ORCPT ); Mon, 24 Mar 2014 06:08:40 -0400 From: Kalle Valo To: Janusz Dziedzic CC: , Subject: Re: [PATCH 2/2] ath10k: fix rssi and rate reporting References: <1395394437-4048-1-git-send-email-janusz.dziedzic@tieto.com> <1395394437-4048-2-git-send-email-janusz.dziedzic@tieto.com> Date: Mon, 24 Mar 2014 12:08:21 +0200 In-Reply-To: <1395394437-4048-2-git-send-email-janusz.dziedzic@tieto.com> (Janusz Dziedzic's message of "Fri, 21 Mar 2014 10:33:57 +0100") Message-ID: <87eh1r7vu2.fsf@kamboji.qca.qualcomm.com> (sfid-20140324_110843_952364_E4FFCB51) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Janusz Dziedzic writes: > RSSI and RATE fields are valid only when START_VALID > bit is set. So, in current implementation we have to > remember/caclulate them when START_VALID and report the same > when only END_VALID is set. In other case during high > RX traffic we will report invalid RSSI (-95) and RATE (6Mbps) > when only END_VALID bit set. > > Signed-off-by: Janusz Dziedzic It's not clear for me what (user visible) bug you are fixing, please describe that in the commit log. -- Kalle Valo