All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't ban default context when stop_rings!=0
Date: Fri, 21 Feb 2014 18:13:51 +0200	[thread overview]
Message-ID: <87eh2wigu8.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <87ha7sihtr.fsf@gaia.fi.intel.com>

Mika Kuoppala <mika.kuoppala@linux.intel.com> writes:

> ville.syrjala@linux.intel.com writes:
>
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> If we've explicitly stopped the rings for testing purposes, don't ban
>> the default context. Fixes kms_flip hang tests.
>>
>
> To keep logs clean from 'unnecessary' hang messages we set stop_rings also on
> all the gem_reset_stats hanging tests. I think this breaks all the ban
> tests on gem_reset_stats.
>
> So we have dig this nice hole, for avoiding dmesg output on cases
> where dmesg output should be valid and justificed.

I think the correct solution is to have white lists for dmesg output
in piglit test runner, so that we can remove this overloading of
stop_rings.

Injecting proper hang should output a proper log message and this
should be testable.

-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-02-21 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 14:26 [PATCH] drm/i915: Don't ban default context when stop_rings!=0 ville.syrjala
2014-02-21 15:52 ` Mika Kuoppala
2014-02-21 16:13   ` Mika Kuoppala [this message]
2014-03-05 13:03     ` Daniel Vetter
2014-02-21 16:30 ` Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eh2wigu8.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.