All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Josef Bacik <jbacik@fb.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	<linux-fsdevel@vger.kernel.org>
Subject: Re: find_fh_dentry returned a DISCONNECTED directory
Date: Fri, 14 Feb 2014 09:14:56 -0800	[thread overview]
Message-ID: <87eh35sjjj.fsf@xmission.com> (raw)
In-Reply-To: <52FE4C1F.2020907@fb.com> (Josef Bacik's message of "Fri, 14 Feb 2014 12:02:23 -0500")

Josef Bacik <jbacik@fb.com> writes:

> So neither of these cases happened, I just didn't see _anything_ in
> the directory when I mounted the fs.  Once I mounted the parent subvol
> and walked into the default subvol I could see everything properly.
> This is with clearing DISCONNECTED and still using d_splice_alias() in
> lookup.
>
> Once I switched d_splice_alias() to d_materialise_unique() in
> btrfs_lookup() everything went back to working as normal.  So I'm
> calling it a win and forgetting we ever had this conversation.
> Thanks,

Yes. d_splice_alias won't find anything unless DCACHE_DISCONNECTED is
set, and dmaterialse_unique is definitely what you want.

Eric


  reply	other threads:[~2014-02-14 17:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 21:27 find_fh_dentry returned a DISCONNECTED directory J. Bruce Fields
2014-02-13 23:45 ` Eric W. Biederman
2014-02-14  3:30   ` J. Bruce Fields
2014-02-14  4:25     ` Eric W. Biederman
2014-02-14 14:46       ` J. Bruce Fields
2014-02-14 15:49         ` Eric W. Biederman
2014-02-14 16:14           ` J. Bruce Fields
2014-02-14 16:38             ` Josef Bacik
2014-02-14 16:45               ` J. Bruce Fields
2014-02-14 17:02                 ` Josef Bacik
2014-02-14 17:14                   ` Eric W. Biederman [this message]
2014-02-14 17:11               ` Eric W. Biederman
2014-02-14 17:02             ` Eric W. Biederman
2014-02-14 22:19               ` J. Bruce Fields
2014-02-14 22:41                 ` J. Bruce Fields
2014-02-14 14:17     ` Josef Bacik
2014-02-14 15:13     ` Josef Bacik
2014-02-14 15:38       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eh35sjjj.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=bfields@fieldses.org \
    --cc=jbacik@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.