From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VZGo7-0005O6-Iz
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:02:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VZGo2-0000fK-OT
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:02:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VZGo2-0000f9-Hu
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:02:14 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1382018101-6102-1-git-send-email-armbru@redhat.com>
	<1382018101-6102-10-git-send-email-armbru@redhat.com>
	<CAFEAcA81vcnhOfGAWJiuMqFzccK5adjvMcd_qEfLL4qti7Ctyw@mail.gmail.com>
Date: Thu, 24 Oct 2013 11:02:07 +0200
In-Reply-To: <CAFEAcA81vcnhOfGAWJiuMqFzccK5adjvMcd_qEfLL4qti7Ctyw@mail.gmail.com>
	(Peter Maydell's message of "Wed, 23 Oct 2013 11:05:27 +0100")
Message-ID: <87eh7boxdc.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 09/10] isa: Clean up use of
	cannot_instantiate_with_device_add_yet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 17 October 2013 14:55,  <armbru@redhat.com> wrote:
>> From: Markus Armbruster <armbru@redhat.com>
>>
>> Drop it when there's no obvious reason why device_add could not work.
>> Else keep and document why.
>>
>> * isa-fdc, port92, i8042, m48t59_isa, mc146818rtc, isa-pit, kvm-pit:
>>   drop (from the last two by dropping it from their abstract base
>>   pit-common)
>
> port92 needs its a20_out qemu_irq line wiring up, doesn't it?
>
> the pit devices have an output IRQ line that needs wiring up.

Good points; I'll have a second look at these two.  Thanks!