From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8uG7-00073s-Tu for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:42:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8uG0-0004GC-8t for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:42:15 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:49209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8uG0-0004Fr-5R for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:42:08 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Aug 2013 11:42:06 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 72658C9004A for ; Mon, 12 Aug 2013 11:42:02 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7CFg4p433751144 for ; Mon, 12 Aug 2013 11:42:04 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7CFg3Eg019844 for ; Mon, 12 Aug 2013 12:42:03 -0300 From: Anthony Liguori In-Reply-To: <5208FF71.7010208@siemens.com> References: <5c0f4c470f93a477cf12751a8106d728a3c319d8.1376049708.git.jan.kiszka@siemens.com> <871u5zhtaa.fsf@codemonkey.ws> <5208FF71.7010208@siemens.com> Date: Mon, 12 Aug 2013 10:41:51 -0500 Message-ID: <87eh9yq5kw.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v2 for 1.6 1/2] memory: Provide separate handling of unassigned io ports accesses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Peter Maydell , Paolo Bonzini , qemu-devel , Andreas =?utf-8?Q?F=C3=A4rber?= Jan Kiszka writes: > Accesses to unassigned io ports shall return -1 on read and be ignored > on write. Ensure these properties via dedicated ops, decoupling us from > the memory core's handling of unassigned accesses. > > Signed-off-by: Jan Kiszka Please top-post. Regards, Anthony Liguori > --- > > Changes in v2: > - avoid breakage in ioport.h for user build > > exec.c | 3 ++- > include/exec/ioport.h | 4 ++++ > ioport.c | 16 ++++++++++++++++ > 3 files changed, 22 insertions(+), 1 deletions(-) > > diff --git a/exec.c b/exec.c > index 3ca9381..9ed598f 100644 > --- a/exec.c > +++ b/exec.c > @@ -1820,7 +1820,8 @@ static void memory_map_init(void) > address_space_init(&address_space_memory, system_memory, "memory"); > > system_io = g_malloc(sizeof(*system_io)); > - memory_region_init(system_io, NULL, "io", 65536); > + memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, "io", > + 65536); > address_space_init(&address_space_io, system_io, "I/O"); > > memory_listener_register(&core_memory_listener, &address_space_memory); > diff --git a/include/exec/ioport.h b/include/exec/ioport.h > index bdd4e96..b3848be 100644 > --- a/include/exec/ioport.h > +++ b/include/exec/ioport.h > @@ -45,6 +45,10 @@ typedef struct MemoryRegionPortio { > > #define PORTIO_END_OF_LIST() { } > > +#ifndef CONFIG_USER_ONLY > +extern const MemoryRegionOps unassigned_io_ops; > +#endif > + > void cpu_outb(pio_addr_t addr, uint8_t val); > void cpu_outw(pio_addr_t addr, uint16_t val); > void cpu_outl(pio_addr_t addr, uint32_t val); > diff --git a/ioport.c b/ioport.c > index 79b7f1a..707cce8 100644 > --- a/ioport.c > +++ b/ioport.c > @@ -44,6 +44,22 @@ typedef struct MemoryRegionPortioList { > MemoryRegionPortio ports[]; > } MemoryRegionPortioList; > > +static uint64_t unassigned_io_read(void *opaque, hwaddr addr, unsigned size) > +{ > + return -1ULL; > +} > + > +static void unassigned_io_write(void *opaque, hwaddr addr, uint64_t val, > + unsigned size) > +{ > +} > + > +const MemoryRegionOps unassigned_io_ops = { > + .read = unassigned_io_read, > + .write = unassigned_io_write, > + .endianness = DEVICE_NATIVE_ENDIAN, > +}; > + > void cpu_outb(pio_addr_t addr, uint8_t val) > { > LOG_IOPORT("outb: %04"FMT_pioaddr" %02"PRIx8"\n", addr, val); > -- > 1.7.3.4