From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1V2ED7-00068x-Ii
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 01:35:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1V2ED5-0006Fb-WE
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 01:35:33 -0400
Received: from ozlabs.org ([2402:b800:7003:1:1::1]:49784)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1V2ED5-0006FM-LA
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 01:35:31 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
In-Reply-To: <CA+aC4ksBr62tX1aiAXnVueixgyvgFu5uq17TEiD8sZRKD_Tp3w@mail.gmail.com>
References: <87li4v8ktz.fsf@rustcorp.com.au>
	<CA+aC4ksBr62tX1aiAXnVueixgyvgFu5uq17TEiD8sZRKD_Tp3w@mail.gmail.com>
Date: Thu, 25 Jul 2013 12:37:32 +0930
Message-ID: <87ehan8hhn.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] vhost acceleration broken?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

Anthony Liguori <anthony@codemonkey.ws> writes:
> On Wed, Jul 24, 2013 at 8:55 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>> Hi all,
>>
>>         Using latest kernel and master qemu, the following doesn't use
>> vhost acceleration:
>>
>> sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost=on -net nic,model=virtio -drive file=$QEMUIMAGE,index=0,media=disk,if=virtio -kernel arch/x86/boot/bzImage -append "root=/dev/vda1 $KARGS $*"
>
> sudo qemu-system-x86_64 -enable-kvm $ARGS -m 1G -netdev
> tap,script=/home/rusty/bin/kvm-ifup,vhost=on,id=net0 -device
> virtio-net-pci,netdev=net0 -drive file=$QEMUIMAGE,if=virtio -kernel
> arch/x86/boot/bzImage -append "root=/dev/vda1 $KARGS $*"
>
> We really ought to strongly deprecate -net because it's misleading.  I
> suspect we can reasonably add a warning for model=virtio saying
> "please don't use this" and eventually remove it entirely.

Thankyou, that works.

I'm sure you've thought more deeply about the qemu cmdline than I have,
so I won't comment.

Cheers,
Rusty.