From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhYbx-0005Yf-1x for qemu-devel@nongnu.org; Wed, 29 May 2013 01:07:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhYbv-0002b2-UW for qemu-devel@nongnu.org; Wed, 29 May 2013 01:07:44 -0400 Received: from ozlabs.org ([2402:b800:7003:1:1::1]:47127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhYbv-0002Sg-Io for qemu-devel@nongnu.org; Wed, 29 May 2013 01:07:43 -0400 From: Rusty Russell In-Reply-To: <877gijak45.fsf@codemonkey.ws> References: <1369581694-1655-1-git-send-email-mst@redhat.com> <20130526175110.GA3115@redhat.com> <20130526181017.GB3115@redhat.com> <51A253C6.7060303@redhat.com> <20130526183747.GB3427@redhat.com> <51A25A2D.8030700@redhat.com> <20130526200251.GA4305@redhat.com> <51A26E95.5000207@redhat.com> <878v314gb2.fsf@codemonkey.ws> <87ehcsptbg.fsf@rustcorp.com.au> <877gijak45.fsf@codemonkey.ws> Date: Wed, 29 May 2013 09:47:15 +0930 Message-ID: <87ehcqod10.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , Paolo Bonzini , "Michael S. Tsirkin" Cc: Peter Maydell , qemu-devel@nongnu.org, Bryan Venteicher , virtualization Anthony Liguori writes: > Rusty Russell writes: > >> Anthony Liguori writes: >>> Paolo Bonzini writes: >>> >>>> Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: >>>>> > My fault. I should have looked at linux/types.h (actually asm-generic/). >>>>> >>>>> Not really, __uX appear in the headers that were posted. >>> >>> Which is a problem because this is a reserved namespace in C99. >> >> Personally, I find it hard to care. What matters is not what the >> standard has carved out, but whether we have clashes, reserved namespace >> or no. And that won't happen for these. >> >> If someone wants to convert all the kernel headers, I won't NAK it >> though. > > virtio headers are special. Linux headers are normally only consumed in > the kernel or in a userspace application running on Linux. > > virtio headers may be used either in a userspace application running on > !Linux (we need to support QEMU on Windows) or even in a foreign kernel. No. s/virtio/SCSI/. s/virtio/if_eth/. s/virtio/TCPIP/. Cheers, Rusty.