From: Rusty Russell <rusty@rustcorp.com.au>
To: Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Bryan Venteicher <mr.kodiak@gmail.com>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code
Date: Mon, 27 May 2013 20:45:31 +0930 [thread overview]
Message-ID: <87ehcsptbg.fsf@rustcorp.com.au> (raw)
In-Reply-To: <878v314gb2.fsf@codemonkey.ws>
Anthony Liguori <anthony@codemonkey.ws> writes:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto:
>>> > My fault. I should have looked at linux/types.h (actually asm-generic/).
>>>
>>> Not really, __uX appear in the headers that were posted.
>
> Which is a problem because this is a reserved namespace in C99.
Personally, I find it hard to care. What matters is not what the
standard has carved out, but whether we have clashes, reserved namespace
or no. And that won't happen for these.
If someone wants to convert all the kernel headers, I won't NAK it
though.
> Perhaps it's even worth moving the headers from uapi/linux to
> uapi/virtio. Rusty, what do you think?
Hmm, #include <virtio/virtio_net.h> etc would be worthwhile if that also
worked on FreeBSD. Bryan CC'd...
Cheers,
Rusty.
next prev parent reply other threads:[~2013-05-27 11:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 15:22 [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 01/11] make: pull in linux-headers on all platforms Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 02/11] scripts/update-linux-headers.sh: add virtio Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 03/11] virtio-9p: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 04/11] virtio-net, eth: use linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 05/11] virtio-blk: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 06/11] virtio-balloon: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 07/11] virtio-rng: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 08/11] virtio-console: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 09/11] virtio: add virtio_ids from linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 10/11] virtio-pci: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 11/11] virtio: use ring structure from linux-headers Michael S. Tsirkin
2013-05-26 15:43 ` [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code Peter Maydell
2013-05-26 17:51 ` Michael S. Tsirkin
2013-05-26 18:00 ` Peter Maydell
2013-05-26 18:10 ` Michael S. Tsirkin
2013-05-26 18:26 ` Paolo Bonzini
2013-05-26 18:37 ` Michael S. Tsirkin
2013-05-26 18:53 ` Paolo Bonzini
2013-05-26 20:02 ` Michael S. Tsirkin
2013-05-26 20:20 ` Paolo Bonzini
2013-05-26 20:49 ` Anthony Liguori
2013-05-26 20:49 ` Anthony Liguori
2013-05-26 21:42 ` Michael S. Tsirkin
2013-05-26 21:42 ` Michael S. Tsirkin
2013-05-27 0:55 ` Anthony Liguori
2013-05-27 0:55 ` Anthony Liguori
2013-05-27 15:02 ` Michael S. Tsirkin
2013-05-27 15:02 ` Michael S. Tsirkin
2013-05-27 16:14 ` Anthony Liguori
2013-05-27 16:14 ` Anthony Liguori
2013-05-28 6:23 ` Michael S. Tsirkin
2013-05-28 6:23 ` Michael S. Tsirkin
2013-05-29 0:14 ` Rusty Russell
2013-05-29 13:05 ` Anthony Liguori
2013-05-29 14:09 ` Michael S. Tsirkin
2013-05-29 14:09 ` Michael S. Tsirkin
2013-05-29 14:58 ` Anthony Liguori
2013-05-29 14:58 ` Anthony Liguori
2013-05-27 11:15 ` Rusty Russell [this message]
2013-05-28 2:55 ` Anthony Liguori
2013-05-29 0:17 ` Rusty Russell
2013-05-29 0:17 ` Rusty Russell
2013-05-29 5:17 ` Bryan Venteicher
2013-05-29 5:17 ` Bryan Venteicher
2013-05-27 10:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehcsptbg.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=anthony@codemonkey.ws \
--cc=mr.kodiak@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.