From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] virtio-spec: Define virtio-mmio registers as LE Date: Fri, 15 Feb 2013 14:27:47 +1030 Message-ID: <87ehgijkjo.fsf@rustcorp.com.au> References: <87wqubkalj.fsf@rustcorp.com.au> <1360839247-9131-1-git-send-email-pawel.moll@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1360839247-9131-1-git-send-email-pawel.moll@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Pawel Moll , "Michael S. Tsirkin" List-Id: virtualization@lists.linuxfoundation.org Pawel Moll writes: > To solve the never-ending confusions between hosts and guests > of different endianess, define all virtio-mmio registers as LE. > > This change should be safe at this stage, because no known > working mixed-endian system exists so there is virtually no > risk of breaking compatibility. > > Signed-off-by: Pawel Moll Applied. We could also move device configuration space to LE, if we wanted. It's a bigger change to the Linux implementation, since we now need accessors for each width, but it might be a good idea. OTOH, getting such a change into qemu might be harder... Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935288Ab3BOEDA (ORCPT ); Thu, 14 Feb 2013 23:03:00 -0500 Received: from ozlabs.org ([203.10.76.45]:56868 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932324Ab3BOEC7 (ORCPT ); Thu, 14 Feb 2013 23:02:59 -0500 From: Rusty Russell To: Pawel Moll Cc: "Michael S. Tsirkin" , Marc Zyngier , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Pawel Moll Subject: Re: [PATCH] virtio-spec: Define virtio-mmio registers as LE In-Reply-To: <1360839247-9131-1-git-send-email-pawel.moll@arm.com> References: <87wqubkalj.fsf@rustcorp.com.au> <1360839247-9131-1-git-send-email-pawel.moll@arm.com> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Fri, 15 Feb 2013 14:27:47 +1030 Message-ID: <87ehgijkjo.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pawel Moll writes: > To solve the never-ending confusions between hosts and guests > of different endianess, define all virtio-mmio registers as LE. > > This change should be safe at this stage, because no known > working mixed-endian system exists so there is virtually no > risk of breaking compatibility. > > Signed-off-by: Pawel Moll Applied. We could also move device configuration space to LE, if we wanted. It's a bigger change to the Linux implementation, since we now need accessors for each width, but it might be a good idea. OTOH, getting such a change into qemu might be harder... Cheers, Rusty.