From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TwAJF-0001Wu-Ag
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 06:40:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TwAA6-0006ry-Sy
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 06:31:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47311)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TwAA6-0006rg-KL
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 06:31:06 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0IBV5tX028948
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 18 Jan 2013 06:31:05 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1358416915-4103-4-git-send-email-kwolf@redhat.com> (Kevin Wolf's
	message of "Thu, 17 Jan 2013 11:01:55 +0100")
References: <1358416915-4103-1-git-send-email-kwolf@redhat.com>
	<1358416915-4103-4-git-send-email-kwolf@redhat.com>
Date: Fri, 18 Jan 2013 12:31:02 +0100
Message-ID: <87ehhik9s9.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 3/3] ahci: Add migration support
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Kevin Wolf <kwolf@redhat.com> wrote:
> From: Jason Baron <jbaron@redhat.com>
>
> Jason tested these patches by migrating Windows 7 and Fedora 17 guests
> (while under I/O) on both piix with ahci attached and on q35 (which has
> a built-in AHCI controller).
>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

The vmstate bits are correct.  If we are still seing crashes, that is
because we haven't got all the state described.  I fully agree with
Stefan suggestion of merging the code but maintaining it no-migratable.

Later, Juan.