From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkwiL-0005cN-VS for qemu-devel@nongnu.org; Tue, 18 Dec 2012 07:56:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkwiJ-0003mP-U5 for qemu-devel@nongnu.org; Tue, 18 Dec 2012 07:56:05 -0500 From: Markus Armbruster References: <1355753160-17544-1-git-send-email-armbru@redhat.com> <1355753160-17544-2-git-send-email-armbru@redhat.com> <6CCD7939-E75F-4EE1-A616-8BD90F4443B2@suse.de> <874njkrb7d.fsf@blackfin.pond.sub.org> <50CF93B3.2090004@suse.de> Date: Tue, 18 Dec 2012 13:55:43 +0100 In-Reply-To: <50CF93B3.2090004@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?= =?utf-8?Q?'s?= message of "Mon, 17 Dec 2012 22:50:43 +0100") Message-ID: <87ehin34fk.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: kwolf@redhat.com, Peter Maydell , Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Aurelien Jarno Andreas F=C3=A4rber writes: > Am 17.12.2012 15:43, schrieb Markus Armbruster: >> Alexander Graf writes: >>=20 >>> On 17.12.2012, at 15:05, Markus Armbruster wrote: >>> >>>> They complicate IDE data structures and keep getting in the way. >>>> Also, TRIM support (commit d353fb72) is broken for them, because >>>> ide_identify() accesses IDEDevice member conf, but IDEDevice exists >>>> only with qdevified controllers. >>>> >>>> The non-qdevified controllers are still there, but attempting to >>>> connect devices to them fails with "IDE controller not qdevified yet; >>>> drive ignored". >>>> >>>> Affected machines: >>>> >>>> * g3beige's first IDE channel (MacIO) >>>> -hda, -hdb are on first channel, and no longer work >>>> -hdc, -hdd are on second channel, and still work >>>> * mac99's second and third IDE channel (MacIO) >>>> All four IDE drives no longer work >>> >>> Nack. This breaks the default targets of qemu-system-ppc and >>> qemu-system-ppc64. >>=20 >> Please tell us how much more time you want to qdevify IDE for these >> targets. Thanks! > > I believe I have a branch with macio QOM'ifications somewhere that I > could revive. I'd appreciate that. > Note that I know little about IDE or block layer and > mainly care about consistent infrastructure there; I vaguely remember > something about the mac's IDE channels being mixed together from two > devices unlike real hardware, guess I would be unable to fix that. Yes, g3beige's first IDE channel is MacIO (not qdevified), second is CMD646 (qdevified), and mac99's first IDE channel is unimplemented, second and third are MacIO (not qdevified). Inhowfar that matches real hardware I don't know. > As for your question, 2013 and a gentle reminder to all involved would > be nice. :) In my experience with IDE qdevification, gentle reminders do not work. But I'd be delighted to be proven wrong. > In particular we have the Soft Freeze coming up shortly > after the holidays, so is this needed for 1.4 Soft Freeze or can it be > deferred to 1.5 or done during the 1.4 Soft Freeze? > > If Aur=C3=A9lien (CC'ed) doesn't manage, I can look at r2d as well. > CC'ing Peter and Andrzej for the arm devices. In time for 1.4 would be good, because it's in the way of the block backend configuration work I'd like to get into 1.4. If I can pull it off in time. Having to hack around IDE silliness that cannot be cleaned up while we still have non-qdevified controllers isn't helping :)