From: Anthony Liguori <aliguori@us.ibm.com>
To: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] event notifier: Fix setup for win32
Date: Wed, 28 Nov 2012 15:37:38 -0600 [thread overview]
Message-ID: <87ehjds925.fsf@codemonkey.ws> (raw)
In-Reply-To: <50AE835B.1020706@siemens.com>
Jan Kiszka <jan.kiszka@siemens.com> writes:
> The event notifier state is only reset by test_and_clear. But we created
> the windows event object with auto-reset, which subtly swallowed events.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> Grr, the last place I looked at after hours of debugging...
>
> event_notifier-win32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/event_notifier-win32.c b/event_notifier-win32.c
> index c723dad..4ed21c2 100644
> --- a/event_notifier-win32.c
> +++ b/event_notifier-win32.c
> @@ -16,7 +16,7 @@
>
> int event_notifier_init(EventNotifier *e, int active)
> {
> - e->event = CreateEvent(NULL, FALSE, FALSE, NULL);
> + e->event = CreateEvent(NULL, TRUE, FALSE, NULL);
> assert(e->event);
> return 0;
> }
> --
> 1.7.3.4
prev parent reply other threads:[~2012-11-28 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 19:56 [Qemu-devel] [PATCH] event notifier: Fix setup for win32 Jan Kiszka
2012-11-23 7:08 ` Stefan Hajnoczi
2012-11-28 11:40 ` [Qemu-devel] [PATCH 1.3] " Paolo Bonzini
2012-11-28 21:37 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehjds925.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.