From: Alexandre Julliard <julliard@winehq.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Subject: Re: [PATCH] emacs: make 'git-status' work with separate git dirs
Date: Sun, 25 Nov 2012 10:06:25 +0100 [thread overview]
Message-ID: <87ehjit5ke.fsf@wine.dyndns.org> (raw)
In-Reply-To: <7v4nkeyzfb.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sat, 24 Nov 2012 22:22:32 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Enrico Scholz <enrico.scholz@sigma-chemnitz.de> writes:
>
>> when trying 'M-x git-status' in a submodule created with recent (1.7.5+)
>> git, the command fails with
>>
>> | ... is not a git working tree
>>
>> This is caused by creating submodules with '--separate-git-dir' but
>> still checking for a working tree by testing for a '.git' directory.
>>
>> The patch fixes this by relaxing the existing detection a little bit.
>>
>> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
>> ---
>
> This script already relies on the assumption that nobody sane would
> create a directory named ".git" that is not a git repository, and
> this loosens the assumption that nobody would create a file named
> ".git", either. So I would think it is a sane thing to do, but just
> in case if the area expert has better ideas, I am forwarding it.
>
> Ack?
Sure, that's fine.
--
Alexandre Julliard
julliard@winehq.org
next prev parent reply other threads:[~2012-11-25 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 15:58 [PATCH] emacs: make 'git-status' work with separate git dirs Enrico Scholz
2012-11-25 6:22 ` Junio C Hamano
2012-11-25 9:06 ` Alexandre Julliard [this message]
2012-11-26 23:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehjit5ke.fsf@wine.dyndns.org \
--to=julliard@winehq.org \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.