From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMjGR-0001Gt-Kl for qemu-devel@nongnu.org; Fri, 12 Oct 2012 13:43:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMjGQ-0008CD-MQ for qemu-devel@nongnu.org; Fri, 12 Oct 2012 13:43:11 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:51546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMjGQ-0008C9-Hf for qemu-devel@nongnu.org; Fri, 12 Oct 2012 13:43:10 -0400 Received: by mail-oa0-f45.google.com with SMTP id i18so2979826oag.4 for ; Fri, 12 Oct 2012 10:43:09 -0700 (PDT) From: Anthony Liguori In-Reply-To: <1349177616-5341-12-git-send-email-quintela@redhat.com> References: <1349177616-5341-1-git-send-email-quintela@redhat.com> <1349177616-5341-12-git-send-email-quintela@redhat.com> Date: Fri, 12 Oct 2012 12:43:04 -0500 Message-ID: <87ehl3k2mv.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 11/41] ram: Export last_ram_offset() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: Paolo Bonzini Juan Quintela writes: > Is the only way of knowing the RAM size. > > Signed-off-by: Juan Quintela > > Reviewed-by: Paolo Bonzini > --- > cpu-all.h | 2 ++ > exec.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/cpu-all.h b/cpu-all.h > index 74d3681..5408782 100644 > --- a/cpu-all.h > +++ b/cpu-all.h > @@ -517,6 +517,8 @@ extern int mem_prealloc; > void dump_exec_info(FILE *f, fprintf_function cpu_fprintf); > #endif /* !CONFIG_USER_ONLY */ > > +ram_addr_t last_ram_offset(void); > + > int cpu_memory_rw_debug(CPUArchState *env, target_ulong addr, > uint8_t *buf, int len, int is_write); cpu-all.h is included by linux-user and ram_addr_t isn't available when !CONFIG_USER_ONLY. This breaks the build which also implies this series has only been tested with a restricted target list. Please make sure you don't submit pull requests without *at least* doing a full build and 'make check'. Regards, Anthony Liguori > > diff --git a/exec.c b/exec.c > index bb6aa4a..e613329 100644 > --- a/exec.c > +++ b/exec.c > @@ -2462,7 +2462,7 @@ static ram_addr_t find_ram_offset(ram_addr_t size) > return offset; > } > > -static ram_addr_t last_ram_offset(void) > +ram_addr_t last_ram_offset(void) > { > RAMBlock *block; > ram_addr_t last = 0; > -- > 1.7.11.4