From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz, hch@lst.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()
Date: Fri, 14 Sep 2012 22:49:21 +0900 [thread overview]
Message-ID: <87ehm4n28u.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20120914133300.GA22390@localhost> (Fengguang Wu's message of "Fri, 14 Sep 2012 21:33:00 +0800")
Fengguang Wu <fengguang.wu@intel.com> writes:
>> > And BDI_CAP_NO_WRITEBACK is expected to be a static/constant flag that
>> > always evaluate to true/false for a given bdi. There will be
>> > correctness problems if you change the BDI_CAP_NO_WRITEBACK flag
>> > dynamically.
>>
>> I'm going to use it as static or per-sb by initialized in
>> fill_super(). And it uses always BDI_CAP_NO_WRITEBACK if sb is
>> available. Because own FS task flush instead.
>
> Ah OK, sorry I didn't quite catch your use case.
>
> But then if you set BDI_CAP_NO_WRITEBACK in the beginning, how come
> __bdi_start_writeback() will be called at all?
If we call mark_inode_dirty(inode), inode goes into bdi->wb.b_dirty.
And sync(2) calls __bdi_start_writeback() for all of bdi if bdi->wb.b_*
is not empty.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2012-09-14 13:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 18:28 [PATCH] Fix queueing work if !bdi_cap_writeback_dirty() OGAWA Hirofumi
2012-09-12 2:42 ` Fengguang Wu
2012-09-12 8:00 ` OGAWA Hirofumi
2012-09-13 0:33 ` Fengguang Wu
2012-09-13 5:41 ` OGAWA Hirofumi
2012-09-13 6:03 ` Fengguang Wu
2012-09-13 6:31 ` OGAWA Hirofumi
2012-09-13 6:39 ` Fengguang Wu
2012-09-13 7:53 ` OGAWA Hirofumi
2012-09-14 11:13 ` OGAWA Hirofumi
2012-09-14 11:18 ` Fengguang Wu
2012-09-14 11:14 ` Fengguang Wu
2012-09-14 12:12 ` OGAWA Hirofumi
2012-09-14 12:53 ` Fengguang Wu
2012-09-14 13:07 ` OGAWA Hirofumi
2012-09-14 13:33 ` Fengguang Wu
2012-09-14 13:49 ` OGAWA Hirofumi [this message]
2012-09-14 13:19 ` Jan Kara
2012-09-14 13:44 ` OGAWA Hirofumi
2012-09-14 14:45 ` Jan Kara
2012-09-14 15:10 ` OGAWA Hirofumi
2012-09-16 21:49 ` Jan Kara
2012-09-16 23:24 ` OGAWA Hirofumi
2012-09-17 8:48 ` Jan Kara
2012-09-17 9:39 ` OGAWA Hirofumi
2012-09-17 9:56 ` Jan Kara
2012-09-17 10:37 ` OGAWA Hirofumi
2012-09-17 15:54 ` Jan Kara
2012-09-17 16:55 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehm4n28u.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.