From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: owasserm@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/6] migration: remove iohandlers before closing the file
Date: Tue, 07 Aug 2012 13:46:46 -0500 [thread overview]
Message-ID: <87ehni5yll.fsf@codemonkey.ws> (raw)
In-Reply-To: <1344354707-27315-5-git-send-email-pbonzini@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> This will be needed as soon as process_incoming_migration will set
> handlers on the file. The patch may be removed if
...?
Regards,
Anthony Liguori
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> savevm.c | 3 +++
> 1 file modificato, 3 inserzioni(+)
>
> diff --git a/savevm.c b/savevm.c
> index 57cae52..8f075e5 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -210,6 +210,7 @@ static int socket_get_buffer(void *opaque, uint8_t *buf, int64_t pos, int size)
> static int socket_close(void *opaque)
> {
> QEMUFileSocket *s = opaque;
> + qemu_set_fd_handler(s->fd, NULL, NULL, NULL);
> close(s->fd);
> g_free(s);
> return 0;
> @@ -238,6 +239,7 @@ static int stdio_pclose(void *opaque)
> {
> QEMUFileStdio *s = opaque;
> int ret;
> + qemu_set_fd_handler(fileno(s->stdio_file), NULL, NULL, NULL);
> ret = pclose(s->stdio_file);
> if (ret == -1) {
> ret = -errno;
> @@ -250,6 +252,7 @@ static int stdio_fclose(void *opaque)
> {
> QEMUFileStdio *s = opaque;
> int ret = 0;
> + qemu_set_fd_handler(fileno(s->stdio_file), NULL, NULL, NULL);
> if (fclose(s->stdio_file) == EOF) {
> ret = -errno;
> }
> --
> 1.7.11.2
next prev parent reply other threads:[~2012-08-07 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 15:51 [Qemu-devel] [RFC PATCH 0/6] Run incoming migration in a coroutine Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 1/6] migration: clean up server sockets and handlers before invoking process_incoming_migration Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 2/6] migration: close socket QEMUFile from socket_close Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 3/6] migration: move qemu_fclose to process_incoming_migration Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 4/6] migration: remove iohandlers before closing the file Paolo Bonzini
2012-08-07 18:46 ` Anthony Liguori [this message]
2012-08-08 8:00 ` Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 5/6] migration: handle EAGAIN while reading QEMUFile Paolo Bonzini
2012-08-07 15:51 ` [Qemu-devel] [PATCH 6/6] migration: move process_incoming_migration to a coroutine Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehni5yll.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.