diff for duplicates of <87ehyfec7t.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index 6e1dc79..f4f6264 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,20 +17,20 @@ Govindraj <govindraj.ti@gmail.com> writes: >>>> [...] >>>> >>>>> @@ -1305,6 +1363,16 @@ static int serial_omap_probe(struct platform_device *pdev) ->>>>> up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE; ->>>>> } +>>>>> ? ? ? ? ? ? ? up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE; +>>>>> ? ? ? } >>>>> ->>>>> + pm_runtime_use_autosuspend(&pdev->dev); ->>>>> + pm_runtime_set_autosuspend_delay(&pdev->dev, ->>>>> + OMAP_UART_AUTOSUSPEND_DELAY); +>>>>> + ? ? pm_runtime_use_autosuspend(&pdev->dev); +>>>>> + ? ? pm_runtime_set_autosuspend_delay(&pdev->dev, +>>>>> + ? ? ? ? ? ? ? ? ? ? OMAP_UART_AUTOSUSPEND_DELAY); >>>>> + ->>>>> + pm_runtime_irq_safe(&pdev->dev); ->>>>> + if (device_may_wakeup(&pdev->dev)) { ->>>>> + pm_runtime_enable(&pdev->dev); +>>>>> + ? ? pm_runtime_irq_safe(&pdev->dev); +>>>>> + ? ? if (device_may_wakeup(&pdev->dev)) { +>>>>> + ? ? ? ? ? ? pm_runtime_enable(&pdev->dev); >>>> >>>> So if device_may_wakeup() is false, runtime PM is not enabled, then... >>>> ->>>>> + pm_runtime_get_sync(&pdev->dev); +>>>>> + ? ? ? ? ? ? pm_runtime_get_sync(&pdev->dev); >>>> >>>> ...this get doesn't happen, and the first register access causes a crash. >>> @@ -42,8 +42,8 @@ Govindraj <govindraj.ti@gmail.com> writes: >> IMO, That's not a very maintainable solution. >> >> What happens when when someone fixes serial.c to only set ->> HWMOD_INIT_NO_IDLE on the console UART? or if we fix things so we don't ->> need INIT_NO_IDLE anymore? Then this will crash. +>> HWMOD_INIT_NO_IDLE on the console UART? ?or if we fix things so we don't +>> need INIT_NO_IDLE anymore? ?Then this will crash. >> >> Driver code should not make assumptions like this about what device init >> code is or isn't doing. @@ -60,7 +60,3 @@ used (at least initially.) That means on power up, all the UARTs are left enabled to consume power even when they're not used. Kevin --- -To unsubscribe from this list: send the line "unsubscribe linux-serial" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 71adeee..25bca50 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,19 +4,10 @@ "ref\0CAAL8m4yrXo4KRYxXxWECU99B6--FCMBDFUbNk+vsBV0Jnt0bcg@mail.gmail.com\0" "ref\087obxkio3e.fsf@ti.com\0" "ref\0CAAL8m4zbdA9rtwLhft8UGQTtvroNbYYoBoq4BG2Eu2nCToX5+w@mail.gmail.com\0" - "From\0Kevin Hilman <khilman@ti.com>\0" - "Subject\0Re: [PATCH v6 09/16] OMAP2+: UART: Add runtime pm support for omap-serial driver\0" + "From\0khilman@ti.com (Kevin Hilman)\0" + "Subject\0[PATCH v6 09/16] OMAP2+: UART: Add runtime pm support for omap-serial driver\0" "Date\0Fri, 14 Oct 2011 10:04:38 -0700\0" - "To\0Govindraj <govindraj.ti@gmail.com>\0" - "Cc\0Tony Lindgren <tony@atomide.com>" - Rajendra Nayak <rnayak@ti.com> - Partha Basak <p-basak2@ti.com> - Govindraj.R <govindraj.raja@ti.com> - Santosh Shilimkar <santosh.shilimkar@ti.com> - linux-serial@vger.kernel.org - Vishwanath Sripathy <vishwanath.bs@ti.com> - linux-omap@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Govindraj <govindraj.ti@gmail.com> writes:\n" @@ -38,20 +29,20 @@ ">>>> [...]\n" ">>>>\n" ">>>>> @@ -1305,6 +1363,16 @@ static int serial_omap_probe(struct platform_device *pdev)\n" - ">>>>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE;\n" - ">>>>> \302\240 \302\240 \302\240 }\n" + ">>>>> ? ? ? ? ? ? ? up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE;\n" + ">>>>> ? ? ? }\n" ">>>>>\n" - ">>>>> + \302\240 \302\240 pm_runtime_use_autosuspend(&pdev->dev);\n" - ">>>>> + \302\240 \302\240 pm_runtime_set_autosuspend_delay(&pdev->dev,\n" - ">>>>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 OMAP_UART_AUTOSUSPEND_DELAY);\n" + ">>>>> + ? ? pm_runtime_use_autosuspend(&pdev->dev);\n" + ">>>>> + ? ? pm_runtime_set_autosuspend_delay(&pdev->dev,\n" + ">>>>> + ? ? ? ? ? ? ? ? ? ? OMAP_UART_AUTOSUSPEND_DELAY);\n" ">>>>> +\n" - ">>>>> + \302\240 \302\240 pm_runtime_irq_safe(&pdev->dev);\n" - ">>>>> + \302\240 \302\240 if (device_may_wakeup(&pdev->dev)) {\n" - ">>>>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 pm_runtime_enable(&pdev->dev);\n" + ">>>>> + ? ? pm_runtime_irq_safe(&pdev->dev);\n" + ">>>>> + ? ? if (device_may_wakeup(&pdev->dev)) {\n" + ">>>>> + ? ? ? ? ? ? pm_runtime_enable(&pdev->dev);\n" ">>>>\n" ">>>> So if device_may_wakeup() is false, runtime PM is not enabled, then...\n" ">>>>\n" - ">>>>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 pm_runtime_get_sync(&pdev->dev);\n" + ">>>>> + ? ? ? ? ? ? pm_runtime_get_sync(&pdev->dev);\n" ">>>>\n" ">>>> ...this get doesn't happen, and the first register access causes a crash.\n" ">>>\n" @@ -63,8 +54,8 @@ ">> IMO, That's not a very maintainable solution.\n" ">>\n" ">> What happens when when someone fixes serial.c to only set\n" - ">> HWMOD_INIT_NO_IDLE on the console UART? \302\240or if we fix things so we don't\n" - ">> need INIT_NO_IDLE anymore? \302\240Then this will crash.\n" + ">> HWMOD_INIT_NO_IDLE on the console UART? ?or if we fix things so we don't\n" + ">> need INIT_NO_IDLE anymore? ?Then this will crash.\n" ">>\n" ">> Driver code should not make assumptions like this about what device init\n" ">> code is or isn't doing.\n" @@ -80,10 +71,6 @@ "used (at least initially.) That means on power up, all the UARTs are\n" "left enabled to consume power even when they're not used.\n" "\n" - "Kevin\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-serial\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Kevin -9ff4a4964a0f03eba3bf457cfd0b0d482f4c257f69225712dc32e44cae141b3a +1bc2247c4e9fc8fa093ec6757e6d0ec5d3e1ef499a5778a17b09e44cbd7aad1b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.