From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xscript@gmx.net>) id 1QyUAw-0004bo-Tp
	for qemu-devel@nongnu.org; Tue, 30 Aug 2011 15:40:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xscript@gmx.net>) id 1QyUAv-0002fa-G7
	for qemu-devel@nongnu.org; Tue, 30 Aug 2011 15:40:46 -0400
Received: from mailout-de.gmx.net ([213.165.64.22]:60078)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <xscript@gmx.net>) id 1QyUAv-0002fQ-4A
	for qemu-devel@nongnu.org; Tue, 30 Aug 2011 15:40:45 -0400
From: =?utf-8?Q?Llu=C3=ADs?= <xscript@gmx.net>
References: <4E5BE7AF.5020906@linux.vnet.ibm.com>
	<1314646068-31438-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<CAJSP0QWY6ofQYpvHLFaO8Ar_UAUno3JEMXJL0yqVzOx5BFimtg@mail.gmail.com>
	<8762lfksyv.fsf@ginnungagap.bsc.es>
	<4E5CFFB6.8000801@linux.vnet.ibm.com>
	<87y5yaiwcq.fsf@ginnungagap.bsc.es>
Date: Tue, 30 Aug 2011 21:40:19 +0200
In-Reply-To: <87y5yaiwcq.fsf@ginnungagap.bsc.es> (=?utf-8?Q?=22Llu=C3=ADs?=
	=?utf-8?Q?=22's?= message of "Tue, 30 Aug 2011 20:32:21 +0200")
Message-ID: <87ei02eli4.fsf@ginnungagap.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle
	qemu-timer-common.o dep
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org

Llu=C3=ADs  writes:

> Michael Roth writes:
>> Hmm, looking again I'm confused why we need to do this in the first plac=
e...the
>> rule is:

>> LINK =3D $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) =
-o=20
>> $@ $(1) $(LIBS),"  LINK  $(TARGET_DIR)$@")

>> %$(EXESUF): %.o
>> $(call LINK,$^)

>> According to the documentation $^ should remove duplicate dependencies, =
so I'm
>> not getting why we need to de-dupe them once they get passed to LINK:

>> http://www.gnu.org/software/make/manual/make.html#index-g_t_0024_005e-948

>> Is there some distinction between duplicate dependencies and duplicate w=
ords in
>> the dependency list?

> It does indeed work X'D

> I was blindly searching for words like "duplicate" and "repeat" in
> make's info page.

> I just now realized that in my case, the duplication error appeared only
> with targets defined in line 434 of Makefile.target.

> The fix is as trivial as using this link line:

>     $(call LINK,$^)


> Nice catch Michael, we got lost in the discussion :)


BTW, I think tis settles the issue with [1] being "The Right Thing" (TM) :)

The patch in [2] is exactly the same, but outside the tracing patch set.


[1] http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03150.html
[2] http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02915.html


Lluis

--=20
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth