From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoweB-0006d6-Ms for qemu-devel@nongnu.org; Thu, 04 Aug 2011 08:03:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoweA-00032I-1Z for qemu-devel@nongnu.org; Thu, 04 Aug 2011 08:03:31 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:37266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qowe9-00032E-Rv for qemu-devel@nongnu.org; Thu, 04 Aug 2011 08:03:30 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p74BXvcl026540 for ; Thu, 4 Aug 2011 07:33:57 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p74C3IFl195818 for ; Thu, 4 Aug 2011 08:03:19 -0400 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7463D34004781 for ; Thu, 4 Aug 2011 00:03:13 -0600 From: "Aneesh Kumar K.V" In-Reply-To: References: <1312452371-10375-1-git-send-email-harsh@linux.vnet.ibm.com> <1312452371-10375-3-git-send-email-harsh@linux.vnet.ibm.com> <87hb5x1kyw.fsf@skywalker.in.ibm.com> Date: Thu, 04 Aug 2011 17:33:08 +0530 Message-ID: <87ei111j0j.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Harsh Prateek Bora , qemu-devel@nongnu.org On Thu, 4 Aug 2011 12:47:42 +0100, Stefan Hajnoczi wro= te: > On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Kumar K.V > wrote: > > On Thu, 4 Aug 2011 11:21:05 +0100, Stefan Hajnoczi = wrote: > >> On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora > >> wrote: > >> > This patch provides support for st_gen for handle based fs type serv= er. > >> > Currently the support is provided for ext4, btrfs, reiserfs and xfs. > >> > > >> > Signed-off-by: Harsh Prateek Bora > >> > --- > >> > =C2=A0hw/9pfs/virtio-9p-handle.c | =C2=A0 30 +++++++++++++++++++++++= +++++++ > >> > =C2=A01 files changed, 30 insertions(+), 0 deletions(-) > >> > >> Does handle-based file I/O really need to duplicate all this code? =C2= =A0Is > >> it possible to use either regular open or handle-based open from a > >> single local fs codebase? > > > > The only details common between handle based and local based getversion > > callback is the ioctl. Moving that into a helper may not really help in > > this case ?. >=20 > Aneesh, do you have a public virtfs tree that I can look at? In > qemu.git we don't have virtio-9p-handle.c yet, so I can't give any > specific feedback. http://repo.or.cz/w/qemu/v9fs.git for-upstream I should send the patchset to qemu list soon. Was waiting for the co-routine patches to go upstream.=20 -aneesh