From: Kevin Hilman <khilman@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, santosh.shilimkar@ti.com,
tony@atomide.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/18] GPIO: OMAP: Driver Cleanup and Fixes
Date: Thu, 16 Jun 2011 09:15:57 -0700 [thread overview]
Message-ID: <87ei2trbuq.fsf@ti.com> (raw)
In-Reply-To: <1308058321-12875-1-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Tue, 14 Jun 2011 19:01:43 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> This series is continuation of cleanup of OMAP GPIO driver and fixes.
> The cleanup include getting rid of cpu_is_* checks wherever possible,
> use of gpio_bank list instead of static array, use of unique platform
> specific value associated data member to OMAP platforms to avoid
> cpu_is_* checks. The series also include PM runtime support.
A quick test of this series on 3430/n900 shows that it prevents PER
retention. I see CM_FCLKEN_PER=0000c000 (debounce clock for GPIO banks
3 & 4 are still enabled.)
Can you retest with debounce enabled on one of the GPIOs for one of your platforms?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/18] GPIO: OMAP: Driver Cleanup and Fixes
Date: Thu, 16 Jun 2011 09:15:57 -0700 [thread overview]
Message-ID: <87ei2trbuq.fsf@ti.com> (raw)
In-Reply-To: <1308058321-12875-1-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Tue, 14 Jun 2011 19:01:43 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> This series is continuation of cleanup of OMAP GPIO driver and fixes.
> The cleanup include getting rid of cpu_is_* checks wherever possible,
> use of gpio_bank list instead of static array, use of unique platform
> specific value associated data member to OMAP platforms to avoid
> cpu_is_* checks. The series also include PM runtime support.
A quick test of this series on 3430/n900 shows that it prevents PER
retention. I see CM_FCLKEN_PER=0000c000 (debounce clock for GPIO banks
3 & 4 are still enabled.)
Can you retest with debounce enabled on one of the GPIOs for one of your platforms?
Kevin
next prev parent reply other threads:[~2011-06-16 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 13:31 [PATCH v2 00/18] GPIO: OMAP: Driver Cleanup and Fixes Tarun Kanti DebBarma
2011-06-14 13:31 ` Tarun Kanti DebBarma
2011-06-16 16:15 ` Kevin Hilman [this message]
2011-06-16 16:15 ` Kevin Hilman
2011-06-17 5:42 ` DebBarma, Tarun Kanti
2011-06-17 5:42 ` DebBarma, Tarun Kanti
2011-06-20 20:00 ` DebBarma, Tarun Kanti
2011-06-20 20:00 ` DebBarma, Tarun Kanti
-- strict thread matches above, loose matches on Subject: below --
2011-06-15 4:03 Tarun Kanti DebBarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei2trbuq.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.