From: Alexandre Julliard <julliard@winehq.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Lawrence Mitchell" <wence@gmx.li>,
git@vger.kernel.org, "David Kågedal" <davidk@lysator.liu.se>,
"Kevin Ryde" <user42@zip.com.au>
Subject: Re: [PATCH] git.el: Don't use font-lock-compile-keywords
Date: Sun, 03 Apr 2011 19:44:55 +0200 [thread overview]
Message-ID: <87ei5j2prc.fsf@wine.dyndns.org> (raw)
In-Reply-To: <20110403001902.GA25671@elie> (Jonathan Nieder's message of "Sat, 2 Apr 2011 19:19:02 -0500")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> So here it is
>> again. The originally proposed patch from Debian is to use
>> font-lock-add-keywords rather than font-lock-compile-keywords.
>> However, it doesn't exist in XEmacs, if one is looking to
>> maintain compatibility, I believe this patch is the right thing
>> to do.
>>
>> contrib/emacs/git.el | 13 ++++++++++---
>> 1 files changed, 10 insertions(+), 3 deletions(-)
>
> Leaving patch unsnipped for reviewers' sake.
Looks good to me.
--
Alexandre Julliard
julliard@winehq.org
next prev parent reply other threads:[~2011-04-03 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 10:59 [PATCH] git.el: Don't use font-lock-compile-keywords Lawrence Mitchell
2011-04-03 0:19 ` Jonathan Nieder
2011-04-03 17:44 ` Alexandre Julliard [this message]
2011-04-03 19:25 ` Jonathan Nieder
2011-04-03 19:26 ` Junio C Hamano
2011-04-04 23:15 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei5j2prc.fsf@wine.dyndns.org \
--to=julliard@winehq.org \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=user42@zip.com.au \
--cc=wence@gmx.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.