Re: [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF

[Kevin Hilman <khilman@ti.com>]

Paul Walmsley <paul@pwsan.com> writes:

> On Tue, 8 Mar 2011, Santosh Shilimkar wrote:
>
>> As per OMAP4430 TRM, the dynamic dependency between MEMIF and MPUSS
>> clockdomains is enable by default. Refer register CM_MPU_DYNAMICDEP
>> description for details.
>> 
>> But it doesn't seems to work as expected and MPUSS doesn't wakeup
>> from off-mode if the static dependency is not set between MPUSS and
>> EMIF clockdomains. i.e CM_MPU_STATICDEP.MEMIF_STATDEP = 0
>> 
>> The issue is under investigation with hardware team.
>> 
>> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>> Cc: Paul Walmsley <paul@pwsan.com>
>> Cc: Kevin Hilman <khilman@ti.com>
>
> Nice work!
>
> Kevin, you want to take this one?

Yup

> My only comment is that it might be nice to add a pr_info("OMAP4 
> PM: Temporary static dependency added between EMIF and MPUSS");
> in there to reduce the risk that the issue will be forgotten...
>
> Acked-by: Paul Walmsley <paul@pwsan.com>

Santosh, 

Please update with the pr_info() as suggested by Paul, repost with
linux-arm-kernel in Cc, add Paul's ack and I'll queue for 2.6.39.

Thanks,

Kevin