From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v6 0/5] da850-evm: add gpio-{keys,leds} for UI and BB expanders Date: Tue, 14 Dec 2010 09:10:19 -0800 Message-ID: <87ei9kwa9w.fsf@deeprootsystems.com> References: <87tyild2ms.fsf@deeprootsystems.com> <8762ux49w7.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: (Ben Gardiner's message of "Tue, 14 Dec 2010 11:17:14 -0500") Sender: linux-kernel-owner@vger.kernel.org To: Ben Gardiner Cc: davinci-linux-open-source@linux.davincidsp.com, linux-input@vger.kernel.org, Dmitry Torokhov , linux-kernel@vger.kernel.org, Chris Cordahi , Paul Mundt , Sekhar Nori , Gabor Juhos List-Id: linux-input@vger.kernel.org Ben Gardiner writes: > On Mon, Dec 13, 2010 at 4:53 PM, Kevin Hilman > wrote: >> Ben Gardiner writes: >>> [...] >>> Everything seems to be in order there; I tested the resulting kernel >>> with evtest and the expected output was observed. Note that >>> davinci-next still contains the cherry-pick of the upstream commit of >>> the polled gpio keys driver: >> >> oops... I've now removed that, since it is part of v2.6.36-rc5 already. >> Thanks for checking. > > Oops on my part... > [...] > It appears that dropping the cherry-pick caused the build failure. > > The commit that introduces the polled gpio keys driver (which was > included in the series as a cherry pick) is commit > 0e7d0c860a0dee49dacb7bbb248d1eba637075ad which is in > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git#master > _after_ the tag v2.6.37-rc5. > > That's my fault. I incorrectly thought that commit > 0e7d0c860a0dee49dacb7bbb248d1eba637075ad was _in_ 2.6.37-rc5 and > stated this is previous emails. I'm sorry for the confusion; I think I > jumped the gun there due to my excitement at getting this prerequisite > driver committed. OK, while waiting for it to arrive upstream, I've added it to my 'davinci-backports' branch, which is also merged into the master branch of davinci git (but not in davinci-next, since it will go upstream via another subsystem.) Just pushed an updated version, and this time, I actually build tested for davinci_all_defconfig and da8xx_omapl_defconfig. :) Sorry for the churn, Kevin