From: Kevin Hilman <khilman@deeprootsystems.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Cousson, Benoit" <b-cousson@ti.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
"Sawant, Anand" <sawant@ti.com>
Subject: Re: [PATCH v2 00/11] OMAP: DMA: HWMOD and DMA as platform driver
Date: Fri, 03 Sep 2010 15:49:49 -0700 [thread overview]
Message-ID: <87eidatpbm.fsf@deeprootsystems.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402781CE908@dbde02.ent.ti.com> (Manjunath Kondaiah G.'s message of "Fri, 3 Sep 2010 21:51:53 +0530")
"G, Manjunath Kondaiah" <manjugk@ti.com> writes:
> If there are no further comments, can you please stage this patch
> series on hwmods-omap4 branch?
Reviewed. Still a long ways to go..., also I didn't see you address
the typo pointed out by Mika Westerberg on PATCH 03/11.
Also, testing on omap3430/n900, I noticed an interesting failure during
boot. During boot (in the middle of omap3_pm_init(), a DMA interrupt
fires and the SPI RX callback is called which faults when accessing it's
registers.
I did not debug this further, but is something that needs investigation.
Also, in the next version, please report how it was tested on the
various OMAPs. In particular, what peripherals using DMA were tested.
Just a boot test is not sufficient when making major functional changes
like this. Drivers using DMA need to be tested as well.
Kevin
next prev parent reply other threads:[~2010-09-03 22:49 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 11:04 [PATCH v2 00/11] OMAP: DMA: HWMOD and DMA as platform driver Manjunatha GK
2010-08-24 11:04 ` [PATCH v2 01/11] OMAP: DMA: Introduce DMA device attributes Manjunatha GK
2010-08-24 11:04 ` [PATCH v2 02/11] OMAP2420: DMA: HWMOD: Add hwmod data structures Manjunatha GK
2010-08-24 11:04 ` [PATCH v2 03/11] OMAP2430: " Manjunatha GK
2010-08-24 11:30 ` Mika Westerberg
2010-08-24 14:32 ` G, Manjunath Kondaiah
2010-08-24 11:04 ` [PATCH v2 04/11] OMAP3: " Manjunatha GK
2010-09-03 20:51 ` Kevin Hilman
2010-09-04 14:45 ` Cousson, Benoit
2010-09-08 1:52 ` G, Manjunath Kondaiah
2010-08-24 11:04 ` [PATCH v2 05/11] OMAP4: " Manjunatha GK
2010-08-24 11:04 ` [PATCH v2 06/11] OMAP1: DMA: Introduce DMA driver as platform driver Manjunatha GK
2010-08-24 11:04 ` [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device registration Manjunatha GK
2010-09-03 20:59 ` Kevin Hilman
2010-09-07 11:47 ` G, Manjunath Kondaiah
2010-09-14 10:18 ` G, Manjunath Kondaiah
2010-09-14 10:24 ` Felipe Balbi
2010-09-14 11:44 ` G, Manjunath Kondaiah
2010-09-14 11:57 ` Felipe Balbi
2010-09-14 14:11 ` G, Manjunath Kondaiah
2010-09-15 7:11 ` Felipe Balbi
2010-09-16 3:40 ` G, Manjunath Kondaiah
2010-09-16 6:03 ` Felipe Balbi
2010-09-16 6:32 ` G, Manjunath Kondaiah
2010-09-16 6:40 ` Felipe Balbi
2010-09-16 6:53 ` G, Manjunath Kondaiah
2010-09-16 6:58 ` Cousson, Benoit
2010-09-16 7:05 ` Felipe Balbi
2010-09-16 14:16 ` Kevin Hilman
2010-08-24 11:04 ` [PATCH v2 08/11] OMAP: DMA: Convert DMA library into DMA platform Driver Manjunatha GK
2010-09-03 22:34 ` Kevin Hilman
2010-09-07 11:47 ` G, Manjunath Kondaiah
2010-09-07 22:45 ` Kevin Hilman
2010-09-08 1:46 ` G, Manjunath Kondaiah
2010-08-24 11:04 ` [PATCH v2 09/11] OMAP: DMA: Implement generic errata handling Manjunatha GK
2010-09-03 22:42 ` Kevin Hilman
2010-09-07 11:48 ` G, Manjunath Kondaiah
2010-09-14 10:12 ` G, Manjunath Kondaiah
2010-09-17 5:05 ` G, Manjunath Kondaiah
2010-09-17 7:24 ` Cousson, Benoit
2010-09-17 8:09 ` G, Manjunath Kondaiah
2010-09-17 10:29 ` Cousson, Benoit
2010-09-17 11:28 ` G, Manjunath Kondaiah
2010-09-17 14:51 ` Cousson, Benoit
2010-09-17 15:32 ` Kevin Hilman
2010-09-18 1:19 ` G, Manjunath Kondaiah
2010-09-18 1:10 ` G, Manjunath Kondaiah
2010-09-17 15:45 ` Cousson, Benoit
2010-09-18 1:15 ` G, Manjunath Kondaiah
2010-08-24 11:04 ` [PATCH v2 10/11] OMAP: DMA: Use DMA device attributes Manjunatha GK
2010-09-03 20:45 ` Kevin Hilman
2010-09-07 11:47 ` G, Manjunath Kondaiah
2010-08-24 11:04 ` [PATCH v2 11/11] sDMA: descriptor autoloading feature Manjunatha GK
2010-09-03 16:21 ` [PATCH v2 00/11] OMAP: DMA: HWMOD and DMA as platform driver G, Manjunath Kondaiah
2010-09-03 16:39 ` Cousson, Benoit
2010-09-07 11:46 ` G, Manjunath Kondaiah
2010-09-03 16:44 ` Kevin Hilman
2010-09-03 22:49 ` Kevin Hilman [this message]
2010-09-07 11:48 ` G, Manjunath Kondaiah
2010-09-08 8:43 ` G, Manjunath Kondaiah
2010-09-03 20:38 ` Kevin Hilman
2010-09-07 11:47 ` G, Manjunath Kondaiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eidatpbm.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=sawant@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.