From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
"Kirill Smelkov" <kirr@landau.phys.spbu.ru>,
"Clément Poulain" <clement.poulain@ensimag.imag.fr>
Subject: Re: [PATCH] git-gui: Use shell to launch textconv filter in "blame"
Date: Fri, 06 Aug 2010 18:56:33 +0100 [thread overview]
Message-ID: <87eieby69a.fsf@fox.patthoyts.tk> (raw)
In-Reply-To: <vpqaap0cees.fsf@bauges.imag.fr> (Matthieu Moy's message of "Fri, 06 Aug 2010 10:51:23 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
[snip]
>
>I'm not very fluent in Tcl, but I don't think this runs the command
>through a shell (pstree agrees with me). That will work in most cases,
>so that may be acceptable, but if you want to have full compatibility
>with what "git blame" does (by using a shell) and allow e.g.
>
>textconv = LANG=C some-command
>
>or
>
>textconv = cd ../; do-whatever
>
>which are already managed by "git blame" and are OK with my version,
>it's not going to do it.
OK compatibility with 'git blame' is a valid reason to do it your
way. Tcl's exec (or open| is equivalent) doesn't go via shell. I'll
check this on windows and apply it. Thanks.
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
next prev parent reply other threads:[~2010-08-06 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 19:25 [BUG] git gui blame fails for multi-word textconv filter Kirill Smelkov
2010-08-04 23:46 ` Clément Poulain
2010-08-05 9:59 ` Matthieu Moy
2010-08-05 10:05 ` [PATCH] git-gui: Use shell to launch textconv filter in "blame" Matthieu Moy
2010-08-05 23:10 ` Pat Thoyts
2010-08-06 8:51 ` Matthieu Moy
2010-08-06 17:56 ` Pat Thoyts [this message]
2010-08-05 22:58 ` [BUG] git gui blame fails for multi-word textconv filter Pat Thoyts
2010-08-19 8:05 ` Kirill Smelkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eieby69a.fsf@fox.patthoyts.tk \
--to=patthoyts@users.sourceforge.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=clement.poulain@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=kirr@landau.phys.spbu.ru \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.