From: Kalle Valo <kalle.valo@iki.fi>
To: Paul.Hampson@Pobox.com
Cc: Pavel Roskin <proski@gnu.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix tx select key null pointer crash with hostapd
Date: Sat, 23 Jan 2010 20:33:03 +0200 [thread overview]
Message-ID: <87eilgpt7k.fsf@purkki.valot.fi> (raw)
In-Reply-To: <20100123182714.15374.3093.stgit@tikku> (Kalle Valo's message of "Sat\, 23 Jan 2010 20\:27\:14 +0200")
Kalle Valo <kalle.valo@iki.fi> writes:
> Pavel Roskin reported a crash in ieee80211_tx_h_select_key():
>
> http://marc.info/?l=linux-wireless&m=126419655108528&w=2
>
> This is a regression from patch "mac80211: move control.hw_key assignment".
> Fix it as suggested by Johannes, adding an else statement to make sure
> that tx->key is not accessed when it's null.
Paul, if you have the time, please try this patch. It should solve
your issue.
In case you are not subcribed to the list, the patch is here:
http://marc.info/?l=linux-wireless&m=126427124317427&w=2
--
Kalle Valo
next prev parent reply other threads:[~2010-01-23 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 18:27 [PATCH] mac80211: fix tx select key null pointer crash with hostapd Kalle Valo
2010-01-23 18:33 ` Kalle Valo [this message]
2010-01-23 19:01 ` Bob Copeland
2010-01-23 21:39 ` Markus Baier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eilgpt7k.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=Paul.Hampson@Pobox.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.