All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Aguirre, Sergio" <saaguirre@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS
Date: Thu, 14 Jan 2010 10:33:10 -0800	[thread overview]
Message-ID: <87eils8rkp.fsf@deeprootsystems.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE894451538FE7@dlee02.ent.ti.com> (Sergio Aguirre's message of "Thu\, 14 Jan 2010 11\:05\:55 -0600")

"Aguirre, Sergio" <saaguirre@ti.com> writes:

> From ec3f04ec8cf4851fceb249acf832755b7aad1766 Mon Sep 17 00:00:00 2001
> From: Sergio Aguirre <saaguirre@ti.com>
> Date: Thu, 14 Jan 2010 11:01:15 -0600
> Subject: [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS
>
> Fix following warning when CONFIG_DEBUG_FS wasn't selected:
>
> arch/arm/mach-omap2/pm-debug.c:57: warning: 'pm_dbg_init' declared 'static' but never defined
>
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>

Thanks, adding to PM branch and queuing in pm-fixes for 2.6.33-rc.

Kevin

> ---
>  arch/arm/mach-omap2/pm-debug.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
> index 860b755..9727484 100644
> --- a/arch/arm/mach-omap2/pm-debug.c
> +++ b/arch/arm/mach-omap2/pm-debug.c
> @@ -54,8 +54,6 @@ int omap2_pm_debug;
>  	regs[reg_count++].val = \
>  			 __raw_readl(OMAP2_L4_IO_ADDRESS(0x480fe000 + (off)))
>  
> -static int __init pm_dbg_init(void);
> -
>  void omap2_pm_dump(int mode, int resume, unsigned int us)
>  {
>  	struct reg {
> @@ -167,6 +165,8 @@ struct dentry *pm_dbg_dir;
>  
>  static int pm_dbg_init_done;
>  
> +static int __init pm_dbg_init(void);
> +
>  enum {
>  	DEBUG_FILE_COUNTERS = 0,
>  	DEBUG_FILE_TIMERS,
> -- 
> 1.6.5.3

      reply	other threads:[~2010-01-14 18:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14 17:05 [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS Aguirre, Sergio
2010-01-14 18:33 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eils8rkp.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=saaguirre@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.