All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Artem Bityutskiy <dedekind@infradead.org>,
	Dave Airlie <airlied@redhat.com>,
	Adrian Hunter <adrian.hunter@nokia.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] sort: Introduce generic list_sort function
Date: Tue, 05 Jan 2010 12:31:15 +0100	[thread overview]
Message-ID: <87eim4dbzw.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1262649295-28427-1-git-send-email-david__25057.2445955642$1262651404$gmane$org@fromorbit.com> (Dave Chinner's message of "Tue, 5 Jan 2010 10:54:55 +1100")

Dave Chinner <david@fromorbit.com> writes:
> +
> +/**
> + * list_sort - sort a list.
> + * @priv: private data, passed to @cmp
> + * @head: the list to sort
> + * @cmp: the elements comparison function
> + *
> + * This function has been implemented by Mark J Roberts <mjr@znex.org>. It
> + * implements "merge sort" which has O(nlog(n)) complexity. The list is sorted
> + * in ascending order.
> + *
> + * The comparison function @cmp is supposed to return a negative value if @a is
> + * than @b, and a positive value if @a is greater than @b. If @a and @b are
> + * equivalent, then it does not matter what this function returns.
> + */
> +void list_sort(void *priv, struct list_head *head,
> +	       int (*cmp)(void *priv, struct list_head *a,
> +			  struct list_head *b))

No EXPORT_SYMBOL? 

Also it would seem cleaner to have it in a own file.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, Artem Bityutskiy <dedekind@infradead.org>,
	Dave Airlie <airlied@redhat.com>,
	linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH] sort: Introduce generic list_sort function
Date: Tue, 05 Jan 2010 12:31:15 +0100	[thread overview]
Message-ID: <87eim4dbzw.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1262649295-28427-1-git-send-email-david__25057.2445955642$1262651404$gmane$org@fromorbit.com> (Dave Chinner's message of "Tue,  5 Jan 2010 10:54:55 +1100")

Dave Chinner <david@fromorbit.com> writes:
> +
> +/**
> + * list_sort - sort a list.
> + * @priv: private data, passed to @cmp
> + * @head: the list to sort
> + * @cmp: the elements comparison function
> + *
> + * This function has been implemented by Mark J Roberts <mjr@znex.org>. It
> + * implements "merge sort" which has O(nlog(n)) complexity. The list is sorted
> + * in ascending order.
> + *
> + * The comparison function @cmp is supposed to return a negative value if @a is
> + * than @b, and a positive value if @a is greater than @b. If @a and @b are
> + * equivalent, then it does not matter what this function returns.
> + */
> +void list_sort(void *priv, struct list_head *head,
> +	       int (*cmp)(void *priv, struct list_head *a,
> +			  struct list_head *b))

No EXPORT_SYMBOL? 

Also it would seem cleaner to have it in a own file.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

       reply	other threads:[~2010-01-05 11:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1262649295-28427-1-git-send-email-david__25057.2445955642$1262651404$gmane$org@fromorbit.com>
2010-01-05 11:31 ` Andi Kleen [this message]
2010-01-05 11:31   ` [PATCH] sort: Introduce generic list_sort function Andi Kleen
2010-01-05 12:21   ` [PATCH V3] " Dave Chinner
2010-01-05 12:21     ` Dave Chinner
2010-01-05 12:52     ` Andi Kleen
2010-01-05 12:52       ` Andi Kleen
2010-01-06 17:23       ` Christoph Hellwig
2010-01-06 17:23         ` Christoph Hellwig
2010-01-06 19:33         ` Andi Kleen
2010-01-06 19:33           ` Andi Kleen
2010-01-04 23:54 [PATCH] " Dave Chinner
2010-01-04 23:54 ` Dave Chinner
2010-01-05  0:48 ` Dave Airlie
2010-01-05  0:48   ` Dave Airlie
2010-01-05  6:23 ` Artem Bityutskiy
2010-01-05  6:23   ` Artem Bityutskiy
2010-01-05  6:26 ` Artem Bityutskiy
2010-01-05  6:26   ` Artem Bityutskiy
2010-01-05  9:34   ` Dave Chinner
2010-01-05  9:34     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eim4dbzw.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=adrian.hunter@nokia.com \
    --cc=airlied@redhat.com \
    --cc=david@fromorbit.com \
    --cc=dedekind@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.