From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1My4Zt-0003ZQ-0K
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:11:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1My4Zn-0003Xk-Vt
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:11:44 -0400
Received: from [199.232.76.173] (port=35615 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1My4Zn-0003XM-2f
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:11:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7229)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1My4Zm-0007pv-KC
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:11:38 -0400
Subject: Re: [Qemu-devel] [PATCH 08/10] monitor: Convert bdrv_info() to QObject
References: <1255037747-3340-1-git-send-email-lcapitulino@redhat.com>
	<1255037747-3340-9-git-send-email-lcapitulino@redhat.com>
	<87bpkf1lz8.fsf@pike.pond.sub.org> <20091014102340.7c3c071c@doriath>
From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 14 Oct 2009 16:11:36 +0200
In-Reply-To: <20091014102340.7c3c071c@doriath> (Luiz Capitulino's message of
	"Wed\, 14 Oct 2009 10\:23\:40 -0300")
Message-ID: <87eip612w7.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Sat, 10 Oct 2009 14:18:03 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Luiz Capitulino <lcapitulino@redhat.com> writes:
>> 
>> > Each block device information is stored in a QDict and the
>> > returned QObject is a QList of all devices.
>> >
>> > The QDict contains the following:
>> >
>> > - "device": device name
>> > - "type": device type
>> > - "removable": 1 if the device is removable 0 otherwise
>> > - "locked": 1 if the device is locked 0 otherwise
>> > - "backing_file": backing file name if one is used
>> 
>> Isn't this in "interted" rather than here?
>> 
>> If yes, the comment in the code needs fixing, too.
>
>  Yes, although I don't think I should resend just because of that.

Any other way to reliably avoid commit of a misleading comment with a
misleading commit message?

If it goes in that way, we need to follow up with a commit fixing the
comment.