From: Andi Kleen <andi@firstfloor.org>
To: "Gurudatt, Sreenidhi B" <sreenidhi.b.gurudatt@intel.com>,
pazke@centrinvest.ru
Cc: "x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alan Cox <alan@linux.intel.com>
Subject: Re: x86: IPC driver patch for Intel Moorestown platform
Date: Tue, 21 Jul 2009 09:25:29 +0200 [thread overview]
Message-ID: <87eisa33bq.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20090721065021.GC11781@centrinvest.ru> (Andrey Panin's message of "Tue, 21 Jul 2009 10:50:21 +0400")
"Andrey Panin" <pazke@centrinvest.ru> writes:
Andrey, Your review would be easier to read if you removed the code
you're not commenting on.
>
> This inline function defined after being used. It's hard to tell whether gcc
> will actually inline it.
Near all supported gccs use "unit at a time" mode now and it's enabled,
so the order of functions in the file doesn't matter for inlining.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-07-21 7:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 1:28 x86: IPC driver patch for Intel Moorestown platform Gurudatt, Sreenidhi B
2009-07-21 6:50 ` Andrey Panin
2009-07-21 7:25 ` Andi Kleen [this message]
2009-07-21 11:29 ` Christoph Hellwig
2009-07-21 11:24 ` Arnd Bergmann
2009-07-21 12:10 ` Alan Cox
2009-07-21 15:00 ` Arnd Bergmann
2009-07-21 15:10 ` Alan Cox
2009-07-21 15:23 ` Arnd Bergmann
2009-07-21 16:00 ` Gurudatt, Sreenidhi B
2009-07-21 16:35 ` Arnd Bergmann
2009-07-21 19:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eisa33bq.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@centrinvest.ru \
--cc=sreenidhi.b.gurudatt@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.