From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1I24n8-0001Ix-SO for mharc-grub-devel@gnu.org; Sat, 23 Jun 2007 08:32:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I24n6-0001Ho-Ox for grub-devel@gnu.org; Sat, 23 Jun 2007 08:32:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I24n4-0001Gq-Ek for grub-devel@gnu.org; Sat, 23 Jun 2007 08:32:35 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I24n4-0001Gi-60 for grub-devel@gnu.org; Sat, 23 Jun 2007 08:32:34 -0400 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1I24n3-0004bo-Mb for grub-devel@gnu.org; Sat, 23 Jun 2007 08:32:33 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id l5NCWTf7087530 for ; Sat, 23 Jun 2007 14:32:30 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20070623115827.GA27818@aragorn> Mail-Copies-To: mgerards@xs4all.nl Date: Sat, 23 Jun 2007 14:32:47 +0200 In-Reply-To: <20070623115827.GA27818@aragorn> (Robert Millan's message of "Sat, 23 Jun 2007 13:58:27 +0200") Message-ID: <87ejk2onps.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 Subject: Re: serial module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2007 12:32:36 -0000 Robert Millan writes: Hi, > Any reason why the serial module is not enabled in i386-pc builds? (see > diff below) You forgot a changelog entry :-/ > diff -ur grub2-1.95+20070621.old/conf/i386-pc.rmk grub2-1.95+20070621/conf/i386-pc.rmk > --- grub2-1.95+20070621.old/conf/i386-pc.rmk 2007-06-11 08:26:18.000000000 +0200 > +++ grub2-1.95+20070621/conf/i386-pc.rmk 2007-06-23 13:56:12.000000000 +0200 > @@ -91,7 +91,7 @@ > commands/terminal.c commands/ls.c commands/test.c \ > commands/search.c commands/blocklist.c \ > commands/i386/pc/halt.c commands/i386/pc/reboot.c \ > - commands/i386/cpuid.c \ > + commands/i386/cpuid.c term/i386/pc/serial.c \ Why do you add it to grub-emu? This is wrong because you can't access the hardware from grub-emu. The same is true for cpuid, I think. Are you sure it works in grub-emu? Please test if it still builds, when adding stuff. > disk/loopback.c disk/raid.c disk/lvm.c \ > fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \ > fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \ > @@ -131,7 +131,7 @@ > pkgdata_MODULES = _chain.mod _linux.mod linux.mod normal.mod \ > _multiboot.mod chain.mod multiboot.mod reboot.mod halt.mod \ > vbe.mod vbetest.mod vbeinfo.mod video.mod gfxterm.mod \ > - videotest.mod play.mod bitmap.mod tga.mod cpuid.mod > + videotest.mod play.mod bitmap.mod tga.mod cpuid.mod serial.mod Good catch, I also wonder why this wasn't added. Can you please apply this change? -- Marco