From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HvGTZ-0002Ds-Qu for mharc-grub-devel@gnu.org; Mon, 04 Jun 2007 13:36:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HvGTY-0002DQ-Bm for grub-devel@gnu.org; Mon, 04 Jun 2007 13:36:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HvGTW-0002CW-LJ for grub-devel@gnu.org; Mon, 04 Jun 2007 13:36:15 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HvGTW-0002CQ-Hu for grub-devel@gnu.org; Mon, 04 Jun 2007 13:36:14 -0400 Received: from neonescio.viaisn.org ([82.94.249.43]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HvGTW-0006oK-3K for grub-devel@gnu.org; Mon, 04 Jun 2007 13:36:14 -0400 Received: from dijkstra.dekkers.cx ([2001:960:7a0:0:213:d4ff:fe9c:2487] ident=Debian-exim) by neonescio.viaisn.org with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32 CV=0) (Exim 4.63 #1) id 1HvGTD-0008Bm-Oa for grub-devel@gnu.org; Mon, 04 Jun 2007 19:35:55 +0200 Received: from localhost ([127.0.0.1] helo=dijkstra.dekkers.cx ident=jeroen) by dijkstra.dekkers.cx with esmtp (Exim 4.63) (envelope-from ) id 1HvGTC-0002hZ-Cj for grub-devel@gnu.org; Mon, 04 Jun 2007 19:35:54 +0200 Date: Mon, 04 Jun 2007 19:35:54 +0200 Message-ID: <87ejkrr5ad.wl@dekkers.cx> From: Jeroen Dekkers To: The development of GRUB 2 In-Reply-To: <20070604165930.GA17161@aragorn> References: <20070604165930.GA17161@aragorn> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.7 Emacs/22.0.95 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-kernel: Linux 2.6 (newer, 3) Subject: Re: linux headers X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2007 17:36:16 -0000 At Mon, 4 Jun 2007 18:59:30 +0200, Robert Millan wrote: > > > How is it that util/biosdisk.c makes effort to avoid including Linux headers > and defines Linux ioctl macros on its own? > > This adds an extra maintainance burden, so I guess there must be a reason to do > it, but can't think of one.. It only defines it when it isn't defined yet. It seems to be taken from GRUB Legacy's lib/device.c and probably comes from a time those things weren't always defined. The checks for glibc also don't seem that useful to me. It needs a cleanup. Jeroen Dekkers