From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1GfFVV-0004CZ-3M
	for mharc-grub-devel@gnu.org; Wed, 01 Nov 2006 07:47:49 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GfFVT-00048K-0O
	for grub-devel@gnu.org; Wed, 01 Nov 2006 07:47:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GfFVO-0003zg-5T
	for grub-devel@gnu.org; Wed, 01 Nov 2006 07:47:46 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GfFVN-0003zJ-Vb
	for grub-devel@gnu.org; Wed, 01 Nov 2006 07:47:42 -0500
Received: from [195.54.107.79] (helo=mxfep04.bredband.com)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GfFVN-00059w-Rq
	for grub-devel@gnu.org; Wed, 01 Nov 2006 07:47:42 -0500
Received: from ironport.bredband.com ([195.54.107.82] [195.54.107.82])
	by mxfep04.bredband.com with ESMTP id
	<20061101124740.KYGV15709.mxfep04.bredband.com@ironport.bredband.com>
	for <grub-devel@gnu.org>; Wed, 1 Nov 2006 13:47:40 +0100
Received: from c-e8df71d5.029-19-73746f13.cust.bredbandsbolaget.se (HELO
	localhost.localdomain) ([213.113.223.232])
	by ironport.bredband.com with ESMTP; 01 Nov 2006 13:47:40 +0100
From: Johan Rydberg <jrydberg@night.trouble.net>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <1162344225.8547.81.camel@basalt.austin.ibm.com>
Date: Wed, 01 Nov 2006 13:48:36 +0100
In-Reply-To: <1162344225.8547.81.camel@basalt.austin.ibm.com> (Hollis
	Blanchard's message of "Tue, 31 Oct 2006 19:23:45 -0600")
Message-ID: <87ejsnxrh7.fsf@night.trouble.net>
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Subject: Re: [PATCH] generic ELF loading #3
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Nov 2006 12:47:47 -0000

--=-=-=
Content-Transfer-Encoding: quoted-printable

Hollis Blanchard <hollis@penguinppc.org> writes:

> --- grub2-cvs.orig/include/grub/types.h	2006-10-31 19:06:47.000000000 -06=
00
> +++ grub2-cvs/include/grub/types.h	2006-10-31 19:06:58.000000000 -0600
> @@ -23,6 +23,8 @@
>  #include <config.h>
>  #include <grub/cpu/types.h>
>=20=20
> +#define __unused __attribute__ ((unused))
> +

First when I saw this it made me wanna comment on it, and tell you
that defines should all be in uppercase.  But then I poked through the
code, and saw the usage of it, and it looked quite nice, with the
exception of the __-prefix.  There are a lot of "common" words that
are keywords in C; inline, const and auto for example.  Maybe we
should make "unused" a reserved keyword in GRUB?  That would allow
us to write code like;

  int
  grub_foo (int x, unused int foo)
  {
    ...
  }

Just a thought.  Otherwise your patch looked just fine Hollis.

~j

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQBFSJer3CqIy3K3X2ERAilHAKDNPg7B1wRGJzs2R09LnzcRrKlMlgCgoMbN
GWtPq2uE22E7BvwkwlmM1Rw=
=eZKz
-----END PGP SIGNATURE-----
--=-=-=--