From: Jim Meyering <jim@meyering.net>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: git-diff-tree inordinately (O(M*N)) slow on files with many changes
Date: Mon, 16 Oct 2006 18:50:58 +0200 [thread overview]
Message-ID: <87ejt8p5l9.fsf@rho.meyering.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0610160941270.7697@alien.or.mcafeemobile.com> (Davide Libenzi's message of "Mon, 16 Oct 2006 09:42:04 -0700 (PDT)")
Davide Libenzi <davidel@xmailserver.org> wrote:
> On Mon, 16 Oct 2006, Jim Meyering wrote:
>
>> Linus Torvalds <torvalds@osdl.org> wrote:
>> > On Mon, 16 Oct 2006, Linus Torvalds wrote:
>> ...
>> > So I think xdiff has chosen too small a hash. Can you try what happens if
>> > you change xdl_hashbits() (in xdiff/xutil.c) instead? Try making it return
>> > a bigger value (for example, by initializing "bits" to 2 instead of 0),
>> > and see if that makes a difference.
>>
>> It makes no difference.
>>
>> Bear in mind that there are a *lot* of duplicate lines in the files
>> being compared: filtering each through "sort -u" removes 40-50k lines.
>
> Ok, try to bring down XDL_MAX_EQLIMIT to something like 8 or 16 ...
That helps a little.
Now, instead of taking 63s, my test takes ~30s.
(32 for XDL_MAX_EQLIMIT = 16, 30 for XDL_MAX_EQLIMIT = 8)
next prev parent reply other threads:[~2006-10-16 16:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 14:12 git-diff-tree inordinately (O(M*N)) slow on files with many changes Jim Meyering
2006-10-16 15:47 ` Linus Torvalds
2006-10-16 16:12 ` Linus Torvalds
2006-10-16 16:33 ` Jim Meyering
2006-10-16 16:42 ` Davide Libenzi
2006-10-16 16:50 ` Jim Meyering [this message]
2006-10-16 16:54 ` Davide Libenzi
2006-10-16 16:57 ` Jim Meyering
2006-10-16 17:02 ` Davide Libenzi
2006-10-16 17:56 ` Linus Torvalds
2006-10-16 18:03 ` Linus Torvalds
2006-10-16 18:41 ` Davide Libenzi
2006-10-16 18:18 ` Davide Libenzi
2006-10-16 18:51 ` Linus Torvalds
2006-10-16 19:44 ` Davide Libenzi
2006-10-16 20:29 ` Jakub Narebski
2006-10-16 22:53 ` Junio C Hamano
2006-10-16 23:24 ` Linus Torvalds
2006-10-16 23:52 ` Davide Libenzi
2006-10-16 18:24 ` Jim Meyering
2006-10-16 18:30 ` Davide Libenzi
2006-10-16 18:43 ` Jim Meyering
2006-10-16 16:54 ` Linus Torvalds
2006-10-16 16:36 ` Davide Libenzi
2006-10-16 16:57 ` Linus Torvalds
2006-10-16 16:24 ` Davide Libenzi
2006-10-16 16:54 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ejt8p5l9.fsf@rho.meyering.net \
--to=jim@meyering.net \
--cc=davidel@xmailserver.org \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.