From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1GSwZQ-0007II-UK
	for mharc-grub-devel@gnu.org; Thu, 28 Sep 2006 10:09:00 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GSwZP-0007Hn-RS
	for grub-devel@gnu.org; Thu, 28 Sep 2006 10:08:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GSwZN-0007GV-4u
	for grub-devel@gnu.org; Thu, 28 Sep 2006 10:08:58 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GSwZN-0007GQ-0L
	for grub-devel@gnu.org; Thu, 28 Sep 2006 10:08:57 -0400
Received: from [194.109.24.25] (helo=smtp-vbr5.xs4all.nl)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GSweS-0000j9-O2
	for grub-devel@gnu.org; Thu, 28 Sep 2006 10:14:13 -0400
Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net
	[145.99.174.249])
	by smtp-vbr5.xs4all.nl (8.13.8/8.13.8) with ESMTP id k8SE8sm8052758;
	Thu, 28 Sep 2006 16:08:55 +0200 (CEST)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: Johan Rydberg <jrydberg@night.trouble.net>
References: <1159444090.451bb67a38fba@imp6-g19.free.fr>
	<87d59g9jku.fsf@night.trouble.net> <87irj814kp.fsf@xs4all.nl>
	<874pus9ihz.fsf@night.trouble.net>
Mail-Copies-To: mgerards@xs4all.nl
Date: Thu, 28 Sep 2006 16:16:48 +0200
In-Reply-To: <874pus9ihz.fsf@night.trouble.net> (Johan Rydberg's message of
	"Thu, 28 Sep 2006 16:24:24 +0200")
Message-ID: <87ejtw13fz.fsf@xs4all.nl>
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
Cc: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: patch for kern/efi/mm.c (big memmap)
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Sep 2006 14:09:00 -0000

Johan Rydberg <jrydberg@night.trouble.net> writes:

> Marco Gerards <mgerards@xs4all.nl> writes:
>
>>> +  memory_map = grub_efi_allocate_pages
>>> +    (0, 2 * BYTES_TO_PAGES (memory_map_size + 0x1000));
>>>
>>> I suppose you add 0x1000 to round it up.  Maybe we should change
>>> the BYTES_TO_PAGES macro to do roundup.
>>
>> Agreed.  Can you make this change as well?
>
> Done.  See attached patch.

Great, I assume you can fixup the changelog entry as well?

> I'll commit it after I get a few minutes over to test it.

Cool.

--
Marco