From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Dl35F-0007EQ-6n
	for mharc-grub-devel@gnu.org; Wed, 22 Jun 2005 07:07:53 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Dl33p-0006lb-Uy
	for grub-devel@gnu.org; Wed, 22 Jun 2005 07:06:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Dl33a-0006dr-8c
	for grub-devel@gnu.org; Wed, 22 Jun 2005 07:06:20 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Dl33Z-0006L1-8Q
	for grub-devel@gnu.org; Wed, 22 Jun 2005 07:06:09 -0400
Received: from [145.74.66.11] (helo=mail-cn.han.nl)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dl35y-0006Fx-2p
	for grub-devel@gnu.org; Wed, 22 Jun 2005 07:08:38 -0400
Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6])
	by mail-cn.han.nl (Postfix) with ESMTP id 4D64D8782
	for <grub-devel@gnu.org>; Wed, 22 Jun 2005 13:05:28 +0200 (CEST)
Received: from mail-cn.han.nl ([145.74.66.11])
	by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new,
	port 10024) with ESMTP id 00881-03 for <grub-devel@gnu.org>;
	Wed, 22 Jun 2005 12:09:03 +0200 (CEST)
Received: from mail1.han.nl (mail1.han.nl [145.74.103.11])
	by mail-cn.han.nl (Postfix) with ESMTP id 581F386A4
	for <grub-devel@gnu.org>; Wed, 22 Jun 2005 13:05:26 +0200 (CEST)
Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129])
	by mail1.han.nl (Postfix) with ESMTP id 16C27C045
	for <grub-devel@gnu.org>; Wed, 22 Jun 2005 13:05:25 +0200 (CEST)
Mail-Copies-To: metgerards@student.han.nl
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20050621231410.GA26213@miracle>
From: Marco Gerards <metgerards@student.han.nl>
Date: Wed, 22 Jun 2005 13:05:38 +0200
In-Reply-To: <20050621231410.GA26213@miracle> (Hollis Blanchard's message of
	"Tue, 21 Jun 2005 18:14:10 -0500")
Message-ID: <87ekauejnh.fsf@student.han.nl>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl
Subject: Re: [patch] printf long format
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jun 2005 11:07:47 -0000

Hollis Blanchard <hollis@penguinppc.org> writes:

> Debugging a partition map bug, I was adding more grub_dprintf messages...
> and re-discovered that our printf doesn't handle e.g. "%lx" format strings (yet
> gcc requires these when printing longs).

Isn't that hexadecimal?

> 	  * kern/misc.c (grub_vsprintf): Add `longfmt'.  If format string
> 	  contains `l' modifier, get a long from va_arg().

You forgot the first line...  Please make sure the date you use is the
date you check in.  With your previous commit something went wrong.

>  	  if (*fmt && *fmt =='-')
>  	    {
>  	      rightfill = 1;
>  	      fmt++;
>  	    }
> -	  
> +
>  	  p = (char *) fmt;
>  	  /* Read formatting parameters.  */

Please watch out for such stuff.  I know it is annoying...

The patch looks fine to me.

Thanks,
Marco