From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DFCGi-0000kY-0K for mharc-grub-devel@gnu.org; Sat, 26 Mar 2005 09:28:04 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DFCGY-0000hJ-Fa for grub-devel@gnu.org; Sat, 26 Mar 2005 09:27:55 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DFCGQ-0000df-GW for grub-devel@gnu.org; Sat, 26 Mar 2005 09:27:49 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DFCGO-0000Sw-Ru for grub-devel@gnu.org; Sat, 26 Mar 2005 09:27:45 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DFBiA-0001EZ-VW for grub-devel@gnu.org; Sat, 26 Mar 2005 08:52:23 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 7809A9514 for ; Sat, 26 Mar 2005 14:52:22 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 04412-02 for ; Sat, 26 Mar 2005 14:52:21 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 3D4CF950D for ; Sat, 26 Mar 2005 14:52:21 +0100 (CET) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 03722C047 for ; Sat, 26 Mar 2005 14:52:21 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <74cfc9a471d7669b38b24a5a89f35538@free.fr> <200503232145.04398.okuji@enbug.org> <1111616923.4241ed9b706fe@imp5-q.free.fr> <200503260122.10488.okuji@enbug.org> <1111838991.4245510f6e902@imp6-q.free.fr> From: Marco Gerards Date: Sat, 26 Mar 2005 14:52:24 +0100 In-Reply-To: <1111838991.4245510f6e902@imp6-q.free.fr> (Antoine Terrienne's message of "Sat, 26 Mar 2005 13:09:51 +0100") Message-ID: <87eke2qztz.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: Grub2 on Mac OS X X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2005 14:27:58 -0000 Antoine Terrienne writes: > Ok so I guess we should change the getopt method used by grub-mkimage to argp > too. IMHO it should be changed for every utility in that case. If no one knows argp, I could do that when I have some time and some other issues are solved. That would be in some months, but it will be done. > Oop sory I mean stdint.h > Types like int32_t, uint32_t and intprt_t are defined from stdint.h If that is used, you could replace int32_t by grub_uint32_t, etc. > I try to send a new patch several times but it is too big for the mailing list > size limit (100Kb) so I put it here : > http://antoine.terrienne.free.fr/grub2/grub2_on_macosx_20050326.patch Not including generated files will make the patch a lot smaller. I personally don't have problems with big patches on the mailinglist. Having the patch in the email will make it a lot easier for me to review the patch. > And the mail I sent with it : > > Here is a new patch much cleaner (with -u). Please use -p as well. It will make reviewing the patch a *LOT* easier. > Everything compiles now but I didn't test It yet. In fact I don't know how to > use and install grub2 on a drive. If you have and docs or info about installing > a binary to be open firmware bootable that could help me, thanks ;-) First you have to compile GRUB 2. After that you can use grub-mkimage to create an ELF file that is loadable by open firmware. Using grub-mkimage you should specify the name of the output executable and which modules should be included. For testing you should at least include apple.mod, ext2.mod, hfs.mod, ls.mod and normal.mod I think. After that I just load it using "boot" or tftp. > The compilation is OK but this patch is still ugly : I left the getopt. I add a > flag -DGRUB_HOST to make a distinction between the host and build parts. The > GRUB_HOST flag is only used in some specific powerpc include directories so it > shouldn't affect the i386 part. I also add a grub_machine_fini in > kern/powerpc/ieee1275/init.c needed by kern/loader.c. Right now > grub_machine_fini is empty but it should call for someting like > grub_console_fini (not present in powerpc part) and grub_ofdisk_fini (not > implemented). I left malloc as an alternative to memalign. As far as I look in > the code memalign is used to align memory segment from elf files and every > usual cases in elf segments fits in the 16 byte alignment. So it should work > well for now waiting for a better implementation to support exotic segment > alignments. I thought GRUBOF was not used anymore, but I see you replaced it. I hope I can find some time to have a look at your patch soon, but please understand if it will take a while. > Compilation and installation are OK. I get grub-emu grub-mkimage and every > modules in the share/grub/ directory and grub-mkimage can produce images. Still > need test and improvements but it seems to work. Cool! please check if your modification did not add any warnings or so, we would like to keep GRUB quite clean. A complete review has to follow... sorry... Thanks, Marco