From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1CaDyU-0004rD-0s for mharc-grub-devel@gnu.org; Fri, 03 Dec 2004 08:59:54 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CaDyS-0004qw-Bh for grub-devel@gnu.org; Fri, 03 Dec 2004 08:59:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CaDyR-0004qk-TU for grub-devel@gnu.org; Fri, 03 Dec 2004 08:59:52 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CaDyR-0004qh-QK for grub-devel@gnu.org; Fri, 03 Dec 2004 08:59:51 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CaDoh-0000C8-Ah for grub-devel@gnu.org; Fri, 03 Dec 2004 08:49:47 -0500 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 83A6AA405 for ; Fri, 3 Dec 2004 14:08:11 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 05134-03 for ; Fri, 3 Dec 2004 14:08:09 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 34AC3A2FE for ; Fri, 3 Dec 2004 14:08:09 +0100 (CET) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id EB0CAC05A for ; Fri, 3 Dec 2004 14:08:08 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <200411231701.07309.T.E.Baldwin99@members.leeds.ac.uk> <87sm6wrk0a.fsf@marco.marco-g.com> <200411270136.33598.T.E.Baldwin99@members.leeds.ac.uk> <200411271821.34605.T.E.Baldwin99@members.leeds.ac.uk> From: Marco Gerards Date: Fri, 03 Dec 2004 13:07:00 +0000 In-Reply-To: <200411271821.34605.T.E.Baldwin99@members.leeds.ac.uk> (Timothy Baldwin's message of "Sat, 27 Nov 2004 18:21:25 +0000") Message-ID: <87eki7ledn.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: RISC OS port X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2004 13:59:52 -0000 Timothy Baldwin writes: > On Saturday 27 Nov 2004 01:36, I wrote: > >> 1. Portability fixes and configure.ac changes. > > Here they are. However cross-compiling is broken in that > the utilities are only built for the build system, without > this patch they are only built for the host system. Either > way, the result is not a complete installation. Ok. I really hope someone else can have a look at this because I don't know much about autoconf/automake, etc. However, I am trying to comment on your code wherever I can. > I propose to solve this problem by running configure twice > when cross-compiling, once for the host, once for the build > system. This could be done by adding these make rules: > > build/%: build/Makefile > cd build && $(MAKE) $* > touch $@ > > build/Makefile: $(srcdir)/configure > cd build && $(srcdir)/configure --host=$(build) --target=$(host) > > Define BUILD to "build/" when cross compiling or to "" > when not cross-compiling and prefix use of the utilites > in makefiles with $(BUILD). > > Shall I do that? This does not look like a clean solution to me. Normally this is not required to do it like this, right? Can you please make a changelog entry for this patch? > +if test "x$host_cpu" = xarm; then > + AC_PATH_PROG(PERL, perl) > +fi > + Why do you need perl? > + GRUB_ERR_FILE_CLOSE_ERROR, > + GRUB_ERR_FILE_OPEN_ERROR, > + GRUB_ERR_DIR_READ_ERROR When are these errors triggered, btw? Can't you use GRUB_ERR_BAD_FS or GRUB_FS_BAD_FILE_TYPE instead? > diff -purN -x '*.mk' -x '*~' -x autom4te.cache -x configure -x '.#*' -x CVS grub2-submitted/include/grub/misc.h grub2-arm/include/grub/misc.h > --- grub2-submitted/include/grub/misc.h 2004-11-19 00:55:52.000000000 +0000 > +++ grub2-arm/include/grub/misc.h 2004-11-26 21:46:02.000000000 +0000 ... > +void *EXPORT_FUNC(memcpy) (void *dest, const void *src, grub_size_t n); > +void *EXPORT_FUNC(memset) (void *s, int c, grub_size_t n); Why do you want to do this? Can't you just use grub_memcpy and grub_memset instead? > -#define FUNCTION(x) .globl EXT_C(x) ; .type EXT_C(x), @function ; EXT_C(x): > -#define VARIABLE(x) .globl EXT_C(x) ; .type EXT_C(x), @object ; EXT_C(x): > +#define FUNCTION(x) .globl EXT_C(x) ; .type EXT_C(x), "function" ; EXT_C(x): > +#define VARIABLE(x) .globl EXT_C(x) ; .type EXT_C(x), "object" ; EXT_C(x): Can you please explain this change? > } > + > void *memmove (void *dest, const void *src, grub_size_t n) > __attribute__ ((alias ("grub_memmove"))); > + Please watch out with adding white lines. Does GRUB 2 still work on the PC after this patch is committed? Thanks, Marco